Skip to content

[CM-1262] showDeleteImage is now public #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2023
Merged

[CM-1262] showDeleteImage is now public #10

merged 1 commit into from
Mar 22, 2023

Conversation

SahilSainiYML
Copy link
Contributor

@SahilSainiYML SahilSainiYML commented Mar 22, 2023 •
edited
Loading

Introduction

Change access of showDeleteImage from internal to public

Purpose

Make showDeleteImage public.
Fix #9.

📈 Coverage

Code

No change in code coverage.

Documentation

No change in documentation.

@mpospese
Copy link
Contributor

Add Fix #9 to the description

mpospese
mpospese approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@mpospese mpospese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But add Fix #9 prior to merge

@SahilSainiYML SahilSainiYML added the bug Something isn't working label Mar 22, 2023
@SahilSainiYML SahilSainiYML merged commit 5c53347 into main Mar 22, 2023
@SahilSainiYML SahilSainiYML deleted the feature/CM-1262-MakeShowDeleteImagePublic branch March 22, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpospese mpospese mpospese approved these changes

@devkaranCT devkaranCT Awaiting requested review from devkaranCT

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Appearance.showDeleteImage public
2 participants
@SahilSainiYML @mpospese