Skip to content

[Issue 58] Add Animation struct #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

mpospese
Copy link
Contributor

Introduction

There was a request to be able to customize the animations in YSnackbar, but this could get complicated because there are multiple possible overrides of the UIView.animate class functions, and which func needs to be called might depend on how the animation were customized. At first this was a change to YSnackbar, but this functionality is completely generic to UIView, and so could be applied to other libraries than just YSnackbar (perhaps to YBottomSheet, for example).

Purpose

Fix #58 Add Animation struct to support customizing animations

Scope

  • Add new Animation struct
  • Add a new UIView.animate class function that takes an Animation parameter
  • Unit tests
  • Update README

Discussion

I also added README documentation for our Elevation drop shadow struct.

📈 Coverage

Code

100%
image

Documentation

100%
image

@mpospese mpospese added the enhancement New feature or request label Mar 31, 2023
@mpospese mpospese self-assigned this Mar 31, 2023
@mpospese mpospese linked an issue Mar 31, 2023 that may be closed by this pull request
@mpospese mpospese merged commit 962c919 into main Mar 31, 2023
@mpospese mpospese deleted the issue/58-add-animation-struct branch March 31, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Add Animation struct to support customizing animations
2 participants