This repository was archived by the owner on May 20, 2026. It is now read-only.
[Issue-51] Log warnings when fallback image is delivered.#52
Merged
Conversation
mpospese
requested review from
SahilSainiYML,
devkaranCT,
karthikyml,
sanjibchakraborty and
westongpt
March 16, 2023 16:50
devkaranCT
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
When either
ImageAssetorSystemImagefails to load an image and delivers the fallback image instead we should log a warning to the console to alert the developer.Purpose
Fix #51: Optionally log warning to console when delivering the fallback image.
Scope
ImageAsset.imageSystemImage.image📈 Coverage
Code
100%
Documentation
100%
