Skip to content

Conversation

@codeSamuraii
Copy link
Owner

The most notable changes include making the internal batch size configurable, adding detailed debug logging, refactoring the native implementation for clarity and maintainability, and expanding test coverage to ensure robust behavior.

@codeSamuraii codeSamuraii requested a review from Copilot October 11, 2025 21:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates viteo to version 0.1.2, adding configurable batch sizing and comprehensive debug logging. The changes focus on making the internal frame buffering configurable while providing detailed visibility into the video processing pipeline.

Key changes:

  • Added configurable batch size parameter to control internal frame buffering
  • Implemented comprehensive debug logging system activated via VITEO_DEBUG environment variable
  • Refactored native implementation into smaller, more maintainable functions

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/viteo/init.py Added batch_size parameter to FrameExtractor and open() function
src/native/include/frame_extractor.h Updated constructor signature to accept batch_size parameter
src/native/src/frame_extractor.mm Major refactoring with debug logging and extracted helper methods
src/native/src/bindings.cpp Updated Python bindings to handle batch_size and return None for end-of-stream
tests/test_viteo.py Added comprehensive test coverage for end-of-stream behavior
README.md Added documentation for debug logging and batch size configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

codeSamuraii and others added 3 commits October 12, 2025 01:24
Updated rebuilding instructions and added batch size details.
Added docstring, removed whitespace

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Added performance benchmark image to README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants