Added Support for TYPO3 V10 #292
Conversation
| if ($otpInFieldArray2 === null && $otpInPostData2 !== null) { | ||
| $otpInFieldArray2 = $otpInPostData2; | ||
| } | ||
|
|
There was a problem hiding this comment.
After having a closer look, the naming is quite bad here, it should be $secretInFieldArray and $secretInPostData. This is fixed in my own v10 branch here (which is based on this cleaned-up patch): https://github.com/xperseguers/cf_google_authenticator/tree/feature/TYPO3v10
| { | ||
| $this->data = $data; | ||
|
|
||
| $result = $this->initializeResultArray(); |
| $result['html'] = $templateView->render(); | ||
|
|
||
| return $result; | ||
| } |
| 'tableName' => 'fe_users', | ||
| ], | ||
| \CodeFareith\CfGoogleAuthenticator\Domain\Model\BackendUser::class => [ | ||
| 'tableName' => 'be_users', |
| 'depends' => | ||
| array ( | ||
| 'php' => '7.1-', | ||
| 'typo3' => '10.4.99-', |
There was a problem hiding this comment.
Wrong! This is 10.4.0-, possibly with upper bound so that it's officially not (yet) compatible with v11 => 10.4.0-10.4.99
| ), | ||
| 'suggests' => | ||
| array ( | ||
| 'felogin' => '10.4.99-', |
There was a problem hiding this comment.
10.4.99- is wrong for the same reason but I would suggest to drop version compatibility here since felogin is a core extension and a mismatch with core is impossible anyway.
| ), | ||
| 'uploadfolder' => false, | ||
| 'clearcacheonload' => true, | ||
| ); |
There was a problem hiding this comment.
Generally speaking, this whole file is using old array syntax, I don't get why the former clean square bracket syntax has been changed.
| ['felogin'] | ||
| ['postProcContent'] | ||
| [$_EXTKEY] = \CodeFareith\CfGoogleAuthenticator\Hook\FeLogin::class . '->createOneTimePasswordField'; | ||
| [$_EXTKEY] = \CodeFareith\CfGoogleAuthenticator\Hook\FeLogin::class . '->createOneTimePasswordField'; |
|
I've the feeling it would be compatible with v9 as well, which would allow to have a v9-v10 compatibility which always eases the migration. In addition, it looks like |
3 participants
No description provided.