Skip to content

fixed classname add logic on font load #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2022
Merged

fixed classname add logic on font load #30

merged 1 commit into from
Jul 29, 2022

Conversation

@mehimanshupatil
Copy link

class name adding logic was failing since font load promise returns FontFace array while it is handled as string

@mehimanshupatil mehimanshupatil mentioned this pull request Jul 28, 2022
Closed
@codeAdrian
Copy link
Owner

Thanks @mehimanshupatil for your contribution. Great catch! I'll merge it and create a new release.

@codeAdrian codeAdrian merged commit 6e9a9f0 into codeAdrian:main Jul 29, 2022
@mehimanshupatil mehimanshupatil deleted the font-name-error branch July 29, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mehimanshupatil @codeAdrian