249/bugfix_back_button_missed_question: fixed the back button issue #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed problem when back button was not saving properly the answers. There were two issues here, one, it could be the save answers did not finish before syncData and two, updateAnsweredQuestion was not doing anything as there was no emitter call at the end. This was fixed by chaining the rxjava call under one Schedulers.io and also, by chaining saveAnswers and syncData. * Added more logs. * Incorporated changes from code4romania#252.
toaderandrei
force-pushed
the
249/bugfix_back_button_missed_question
branch
from
0e2e11d to
178edad
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues here, one, it could be the save answers did not
finish before syncData and two, updateAnsweredQuestion was not doing
anything as there was no emitter call at the end. This was fixed by
chaining the rxjava call under one Schedulers.io and also, by chaining
saveAnswers and syncData.
Requirements for making a pull request
Thank you for contributing to our project!
Please fill out the template below to help the project maintainers review it as fast as possible and include your contribution to the project.
What does it fix?
Closes
Please mention the main changes this PR brings.
How has it been tested?
Please describe the tests that you ran to verify your changes.