Enable upload of multiple files with note #231
Conversation
|
@lukstbit woooh, looks good! could you also add the possibility of selecting more than one item when loading files from gallery? |
app/src/main/java/ro/code4/monitorizarevot/ui/notes/NoteFragment.kt
Outdated
Show resolved
Hide resolved
lukstbit
force-pushed
the
implement_issue_28
branch
from
cf75d8b to
735e27f
Compare
|
The user can now select one file/multiple files from the gallery in one go! There is also one extra commit where I refactored the error messages shown to the user when copying the file fails. The previous error messages were about storage permission missing but that will happen quite rarely because we check for the permission every time the user sets to select a file/take picture. A more common error would be insufficient storage and I changed the messages to reflect this. If you don't like the change you could remove the last commit. Also, one thing that I forgot to mention in the initial post is that the number of files that could be attached is unlimited, the user has the possibility of adding a lot of file with one note. I don't know if this is desired or if there should be a hard limit on the number of files attached to a single note. |
|
@lukstbit looks great, thanks! you are right, we'll check if there are any file restrictions on the backend and get back on this with another issue ;) btw...are you on the code4ro slack? 😃 |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@aniri I'm not on code4ro I don't even have a Slack account :) |
|
@lukstbit would you like to join us on slack as well? :D We can send you an email invite :D |
|
No, not at this moment. I do plan to implement all the issues currently labeled code4ro-hackdays :) |
@lukstbit awesome! thanks a lot!! we'll have so many new features ready for the elections this december 😃 |
* fix send note on question * Add simple usage for values from remote config at "About page" * Use values from remote config for menu * Copy files to cache instead of using directly. Fixes #178 * Remove file from cache after sending in any sync case * Fix null string property * Made font for selected item in the menu bold (#195) * added collapse keyboard function (#215) * added collapse keyboard function * fix: keyboard collapse and opens again while switching multiple inputs * refactor: collapseKeyboardIfFocusOutsideEditText() to Utils.kt * Use the orderNumber field for sorting (#222) * Use the orderNumber field for sorting * Remove duplication for sonar * Fix sorting for forms (#227) * Sending firebase token on the login call (#225) * Use filesDir instead of cacheDir (#230) * Enable upload of multiple files with note (#231) * Enable uploading multiple files with note * Allow user to select multiple files * Improve error strings for note files * Update app/src/main/res/values-ro-rRO/strings.xml Co-authored-by: Irina Borozan <anirib@gmail.com> * replace: `this` with appropriate lifecycle owner (#224) Co-authored-by: Irina Borozan <anirib@gmail.com> * check db reset remote config flag on startup * cleanups and add default value for remote config param * Add sync related UI changes (#233) * Add sync related UI changes * small layout adjustments * Add latest changes Co-authored-by: Irina Borozan <anirib@gmail.com> * removed extra activate * Allow user to delete note files (#237) * Allow user to delete note files * Handle file deletion failure * Send count of unsynced items to analytics (#244) * Send count of unsynced items to analytics * renamed variable to keep it consistent Co-authored-by: Irina Borozan <anirib@gmail.com> * fixed remote config init error and add min interval setting (#245) * Fix RxJava null values usage (#240) * Fix incorrect selection of counties (#247) * Enable screen for visited polling stations (#241) * Enable screen for visited polling stations * Enable selecting from previously visited stations * added visited stations icon from figma * Implement requested changes * Hide station selection on first run Co-authored-by: Irina Borozan <anirib@gmail.com> * Enable details screen for user's notes (#242) * Enable details screen for user's notes * Implement UI requested changes * Fix issues with form-question codes * Fix adding notes directly from forms list * Tweak UI and save codes for note into database * Update app/src/main/java/ro/code4/monitorizarevot/ui/notes/NoteDetailsFragment.kt * Update app/src/main/res/values/strings.xml * Apply suggestions from code review Co-authored-by: Irina Borozan <anirib@gmail.com> * Add info for visited stations screen (#256) * Fix UI for notes after changing stations (#254) * Bugfix/cleanups on app update (#257) * refactored has selected stations shared pref * fixed db cleanups after app update * Add checks for empty answers list to sync (#252) * added new link in menu and new guide (#259) * changed logout display in menu and default safety link (#260) Co-authored-by: Dmitriy <dekanszn@gmail.com> Co-authored-by: caldareanda <61616802+caldareanda@users.noreply.github.com> Co-authored-by: Avadhut Tanugade <30384908+mrwhoknows55@users.noreply.github.com> Co-authored-by: lukstbit <52494258+lukstbit@users.noreply.github.com> Co-authored-by: Pedro Francisco de Sousa Neto <pedrokra@gmail.com> Co-authored-by: AlexandraDaraban <AlexandraDaraban@users.noreply.github.com>
What does it fix?
Closes #28
To allow the user to add multiple files to a note I kept the add media button always visible. To keep the changes to a minimum I reused the old logic, so instead of the string in the Note class referencing a single path it will represent a concatenation of all the paths to be uploaded with the note. The repository can then extract the paths and make the backend request.
How has it been tested?
I tested the changes manually on various API levels. I plan to add some tests at a later point after some code refactoring.