Skip to content

Commit c20edb8

Browse files
committed
Polish code.
1 parent 0a9fe8d commit c20edb8

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

webmagic-core/src/main/java/us/codecraft/webmagic/downloader/HttpClientDownloader.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,14 @@ public Page download(Request request, Task task) {
7676
CloseableHttpClient httpClient = getHttpClient(task.getSite());
7777
Proxy proxy = proxyProvider != null ? proxyProvider.getProxy(request, task) : null;
7878
HttpClientRequestContext requestContext = httpUriRequestConverter.convert(request, task.getSite(), proxy);
79-
Page page = Page.ofFailure(request);
79+
Page page = null;
8080
try {
8181
httpResponse = httpClient.execute(requestContext.getHttpUriRequest(), requestContext.getHttpClientContext());
8282
page = handleResponse(request, request.getCharset() != null ? request.getCharset() : task.getSite().getCharset(), httpResponse, task);
8383
onSuccess(page, task);
8484
return page;
8585
} catch (IOException e) {
86+
page = Page.ofFailure(request);
8687
onError(page, task, e);
8788
return page;
8889
} finally {

0 commit comments

Comments
 (0)