Add static methods to construct Page.

Author: sutra

webmagic-core/src/main/java/us/codecraft/webmagic/Page.java

@@ -52,9 +52,44 @@ public class Page {
 
     private String charset;
 
+    /**
+     * Returns a {@link Page} with {@link #downloadSuccess} is {@code true},
+     * and {@link #request} is specified.
+     *
+     * @param request the request.
+     * @since 1.0.2
+     */
+    public static Page ofSuccess(Request request) {
+        return new Page(request, true);
+    }
+
+    /**
+     * Returns a {@link Page} with {@link #downloadSuccess} is {@code true},
+     * and {@link #request} is specified.
+     *
+     * @param request the request.
+     * @since 1.0.2
+     */
+    public static Page ofFailure(Request request) {
+        return new Page(request, false);
+    }
+
     public Page() {
     }
 
+    /**
+     * Constructs a {@link Page} with {@link #request}
+     * and {@link #downloadSuccess} specified.
+     *
+     * @param request the request.
+     * @param downloadSuccess the download success flag.
+     * @since 1.0.2
+     */
+    private Page(Request request, boolean downloadSuccess) {
+        this.request = request;
+        this.downloadSuccess = downloadSuccess;
+    }
+
     /**
      * Returns a {@link Page} with {@link #downloadSuccess} is {@code false}.
      *
@@ -73,7 +108,9 @@ public static Page fail() {
      * @param request the {@link Request}.
      * @return the page.
      * @since 0.10.0
+     * @deprecated Use {@link #ofFailure(Request)} instead.
      */
+    @Deprecated(since = "1.0.2", forRemoval = true)
     public static Page fail(Request request){
         Page page = new Page();
         page.setRequest(request);

webmagic-core/src/main/java/us/codecraft/webmagic/downloader/HttpClientDownloader.java

@@ -76,7 +76,7 @@ public Page download(Request request, Task task) {
         CloseableHttpClient httpClient = getHttpClient(task.getSite());
         Proxy proxy = proxyProvider != null ? proxyProvider.getProxy(request, task) : null;
         HttpClientRequestContext requestContext = httpUriRequestConverter.convert(request, task.getSite(), proxy);
-        Page page = Page.fail(request);
+        Page page = Page.ofFailure(request);
         try {
             httpResponse = httpClient.execute(requestContext.getHttpUriRequest(), requestContext.getHttpClientContext());
             page = handleResponse(request, request.getCharset() != null ? request.getCharset() : task.getSite().getCharset(), httpResponse, task);
@@ -105,7 +105,7 @@ protected Page handleResponse(Request request, String charset, HttpResponse http
         HttpEntity entity = httpResponse.getEntity();
         byte[] bytes = entity != null ? IOUtils.toByteArray(entity.getContent()) : new byte[0];
         String contentType = entity != null && entity.getContentType() != null ? entity.getContentType().getValue() : null;
-        Page page = new Page();
+        Page page = Page.ofSuccess(request);
         page.setBytes(bytes);
         if (!request.isBinaryContent()) {
             if (charset == null) {
@@ -117,7 +117,6 @@ protected Page handleResponse(Request request, String charset, HttpResponse http
         page.setUrl(new PlainText(request.getUrl()));
         page.setRequest(request);
         page.setStatusCode(httpResponse.getStatusLine().getStatusCode());
-        page.setDownloadSuccess(true);
         if (responseHeader) {
             page.setHeaders(HttpClientUtils.convertHeaders(httpResponse.getAllHeaders()));
         }