Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reworks the action-related protobuf APIs to remove duplicated RPCs by extracting action configuration into a shared type and introducing dedicated ActionConfiguration services.
Changes:
- Added
shared.ActionConfigurationmessage type in shared protos. - Added
ActionConfigurationServiceprotos for bothsagittariusandaquila. - Simplified Aquila action transfer “first message” from a full configuration payload to a logon identifier/version message; removed the old Sagittarius
ActionServiceproto and updated README structure.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| proto/shared/shared.action_configuration.proto | Introduces a shared ActionConfiguration message to centralize action config types. |
| proto/sagittarius/sagittarius.action_configuration.proto | Adds Sagittarius-side ActionConfiguration update RPC definitions. |
| proto/sagittarius/sagittarius.action.proto | Removes the old Sagittarius ActionService (logon/logoff) proto. |
| proto/aquila/aquila.action_configuration.proto | Adds Aquila-side ActionConfiguration update RPC definitions (currently has namespace/import issues). |
| proto/aquila/aquila.action.proto | Reworks the initial transfer message from “Configuration” to “ActionLogon”. |
| README.md | Updates documentation to reflect new action_configuration services and shared type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #205