Rest FlowType Prototype #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosammito
requested changes
May 4, 2025
definitions/rest.md
Outdated
| } | ||
| ], | ||
| "definition": { | ||
| "editable": false, |
There was a problem hiding this comment.
We can remove the editable config, because its not needed any more
definitions/rest.md
Outdated
| { | ||
| "contains_key": { | ||
| "key": "headers", | ||
| "type": "OBJECT" |
There was a problem hiding this comment.
needs to be more specific with key (TEXT): value (TEXT). ContainsType rule can be used for that
Member
Author
There was a problem hiding this comment.
Created the HTTP_HEADER_MAP & HTTP_HEADER_ENTRY for that
nicosammito
requested changes
May 5, 2025
definitions/rest.md
Outdated
| "rules": [ | ||
| { | ||
| "item_of_collection": { | ||
| "items": [ "GET", "POST", "PUT", "DELETE", "PATCH", "CONNECT", "TRACE", "HEAD", "OPTIONS"] |
definitions/rest.md
Outdated
| } | ||
| } | ||
| ], | ||
| "parent_type_identifier": "TYPE" |
There was a problem hiding this comment.
you never defined the parent_type, so either define this type or remove the parent_type_identifier
definitions/rest.md
Outdated
| } | ||
| } | ||
| ], | ||
| "parent_type_identifier": "TYPE" |
There was a problem hiding this comment.
you never defined the parent_type, so either define this type or remove the parent_type_identifier
definitions/rest.md
Outdated
| { | ||
| "contains_key": { | ||
| "key": "headers", | ||
| "type": "OBJECT" |
There was a problem hiding this comment.
shouldn't this be also of type HTTP_HEADER_MAP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype for the Rest FlowType
Resolves #38