Skip to content

Commit 0df0b44

Browse files
pull[bot]pull[bot]
committed
[Flight] Use more robust web socket implementation in fixture (facebook#34338)
The `WebSocketStream` implementation seems to be a bit unreliable. We've seen `Cannot close a ERRORED writable stream` errors when expanding the logged deep object, for example. And when reducing the fixture to a minimal app, we even get `Connection closed` errors, because the web socket connection is closed before all debug chunks are sent. We can improve the reliability of the web socket connection by using a normal `WebSocket` instance on the client, along with manually creating a `WritableStream` and a `ReadableStream` for processing the messages. As an additional benefit, the debug channel now also works in Firefox and Safari. On the server, we're simplifying the integration with the Express server a bit by utilizing the `server` property for `WebSocket.Server`, instead of the `noServer` property with the manual upgrade handling. DiffTrain build for [3fe51c9](facebook@3fe51c9)
1 parent 33623ac commit 0df0b44

27 files changed

+299
-124
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-89a803fc-20250828
1+
19.2.0-native-fb-3fe51c9e-20250829

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<11f0fd4ba436d9cad88efa403adf3aea>>
10+
* @generated SignedSource<<397ace08d97addab22beb4a02343b064>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-89a803fc-20250828";
407+
exports.version = "19.2.0-native-fb-3fe51c9e-20250829";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<1e386fffe8f0148a90761d2b16aba74f>>
10+
* @generated SignedSource<<517eebeac93aec32689689ae80cd7cc4>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-89a803fc-20250828";
206+
exports.version = "19.2.0-native-fb-3fe51c9e-20250829";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<1e386fffe8f0148a90761d2b16aba74f>>
10+
* @generated SignedSource<<517eebeac93aec32689689ae80cd7cc4>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-89a803fc-20250828";
206+
exports.version = "19.2.0-native-fb-3fe51c9e-20250829";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<7e815673e06505464364678afe55f2a8>>
10+
* @generated SignedSource<<fef08696a9be8cc00ef611a832de593a>>
1111
*/
1212

1313
/*
@@ -29448,11 +29448,11 @@ __DEV__ &&
2944829448
};
2944929449
(function () {
2945029450
var isomorphicReactPackageVersion = React.version;
29451-
if ("19.2.0-native-fb-89a803fc-20250828" !== isomorphicReactPackageVersion)
29451+
if ("19.2.0-native-fb-3fe51c9e-20250829" !== isomorphicReactPackageVersion)
2945229452
throw Error(
2945329453
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2945429454
(isomorphicReactPackageVersion +
29455-
"\n - react-dom: 19.2.0-native-fb-89a803fc-20250828\nLearn more: https://react.dev/warnings/version-mismatch")
29455+
"\n - react-dom: 19.2.0-native-fb-3fe51c9e-20250829\nLearn more: https://react.dev/warnings/version-mismatch")
2945629456
);
2945729457
})();
2945829458
("function" === typeof Map &&
@@ -29489,10 +29489,10 @@ __DEV__ &&
2948929489
!(function () {
2949029490
var internals = {
2949129491
bundleType: 1,
29492-
version: "19.2.0-native-fb-89a803fc-20250828",
29492+
version: "19.2.0-native-fb-3fe51c9e-20250829",
2949329493
rendererPackageName: "react-dom",
2949429494
currentDispatcherRef: ReactSharedInternals,
29495-
reconcilerVersion: "19.2.0-native-fb-89a803fc-20250828"
29495+
reconcilerVersion: "19.2.0-native-fb-3fe51c9e-20250829"
2949629496
};
2949729497
internals.overrideHookState = overrideHookState;
2949829498
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -29631,5 +29631,5 @@ __DEV__ &&
2963129631
listenToAllSupportedEvents(container);
2963229632
return new ReactDOMHydrationRoot(initialChildren);
2963329633
};
29634-
exports.version = "19.2.0-native-fb-89a803fc-20250828";
29634+
exports.version = "19.2.0-native-fb-3fe51c9e-20250829";
2963529635
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<0829c05dd24fcbd6076eb10d8aa40299>>
10+
* @generated SignedSource<<da7dd5db4edd59b594c48a5dd14a71f5>>
1111
*/
1212

1313
/*
@@ -17258,14 +17258,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1725817258
};
1725917259
var isomorphicReactPackageVersion$jscomp$inline_2034 = React.version;
1726017260
if (
17261-
"19.2.0-native-fb-89a803fc-20250828" !==
17261+
"19.2.0-native-fb-3fe51c9e-20250829" !==
1726217262
isomorphicReactPackageVersion$jscomp$inline_2034
1726317263
)
1726417264
throw Error(
1726517265
formatProdErrorMessage(
1726617266
527,
1726717267
isomorphicReactPackageVersion$jscomp$inline_2034,
17268-
"19.2.0-native-fb-89a803fc-20250828"
17268+
"19.2.0-native-fb-3fe51c9e-20250829"
1726917269
)
1727017270
);
1727117271
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17287,10 +17287,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1728717287
};
1728817288
var internals$jscomp$inline_2565 = {
1728917289
bundleType: 0,
17290-
version: "19.2.0-native-fb-89a803fc-20250828",
17290+
version: "19.2.0-native-fb-3fe51c9e-20250829",
1729117291
rendererPackageName: "react-dom",
1729217292
currentDispatcherRef: ReactSharedInternals,
17293-
reconcilerVersion: "19.2.0-native-fb-89a803fc-20250828"
17293+
reconcilerVersion: "19.2.0-native-fb-3fe51c9e-20250829"
1729417294
};
1729517295
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1729617296
var hook$jscomp$inline_2566 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17388,4 +17388,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1738817388
listenToAllSupportedEvents(container);
1738917389
return new ReactDOMHydrationRoot(initialChildren);
1739017390
};
17391-
exports.version = "19.2.0-native-fb-89a803fc-20250828";
17391+
exports.version = "19.2.0-native-fb-3fe51c9e-20250829";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c65196d86cfcb290c2b8933cac22100c>>
10+
* @generated SignedSource<<2558ef1ca156f4efa370d197e8a1d154>>
1111
*/
1212

1313
/*
@@ -19268,14 +19268,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1926819268
};
1926919269
var isomorphicReactPackageVersion$jscomp$inline_2285 = React.version;
1927019270
if (
19271-
"19.2.0-native-fb-89a803fc-20250828" !==
19271+
"19.2.0-native-fb-3fe51c9e-20250829" !==
1927219272
isomorphicReactPackageVersion$jscomp$inline_2285
1927319273
)
1927419274
throw Error(
1927519275
formatProdErrorMessage(
1927619276
527,
1927719277
isomorphicReactPackageVersion$jscomp$inline_2285,
19278-
"19.2.0-native-fb-89a803fc-20250828"
19278+
"19.2.0-native-fb-3fe51c9e-20250829"
1927919279
)
1928019280
);
1928119281
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19297,10 +19297,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1929719297
};
1929819298
var internals$jscomp$inline_2292 = {
1929919299
bundleType: 0,
19300-
version: "19.2.0-native-fb-89a803fc-20250828",
19300+
version: "19.2.0-native-fb-3fe51c9e-20250829",
1930119301
rendererPackageName: "react-dom",
1930219302
currentDispatcherRef: ReactSharedInternals,
19303-
reconcilerVersion: "19.2.0-native-fb-89a803fc-20250828",
19303+
reconcilerVersion: "19.2.0-native-fb-3fe51c9e-20250829",
1930419304
getLaneLabelMap: function () {
1930519305
for (
1930619306
var map = new Map(), lane = 1, index$321 = 0;
@@ -19414,4 +19414,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1941419414
listenToAllSupportedEvents(container);
1941519415
return new ReactDOMHydrationRoot(initialChildren);
1941619416
};
19417-
exports.version = "19.2.0-native-fb-89a803fc-20250828";
19417+
exports.version = "19.2.0-native-fb-3fe51c9e-20250829";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9aeac1f89a9bf16c9028f868199bbf3a>>
10+
* @generated SignedSource<<7bc929677deeafa3ea380b0821c121de>>
1111
*/
1212

1313
/*
@@ -29504,11 +29504,11 @@ __DEV__ &&
2950429504
};
2950529505
(function () {
2950629506
var isomorphicReactPackageVersion = React.version;
29507-
if ("19.2.0-native-fb-89a803fc-20250828" !== isomorphicReactPackageVersion)
29507+
if ("19.2.0-native-fb-3fe51c9e-20250829" !== isomorphicReactPackageVersion)
2950829508
throw Error(
2950929509
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2951029510
(isomorphicReactPackageVersion +
29511-
"\n - react-dom: 19.2.0-native-fb-89a803fc-20250828\nLearn more: https://react.dev/warnings/version-mismatch")
29511+
"\n - react-dom: 19.2.0-native-fb-3fe51c9e-20250829\nLearn more: https://react.dev/warnings/version-mismatch")
2951229512
);
2951329513
})();
2951429514
("function" === typeof Map &&
@@ -29545,10 +29545,10 @@ __DEV__ &&
2954529545
!(function () {
2954629546
var internals = {
2954729547
bundleType: 1,
29548-
version: "19.2.0-native-fb-89a803fc-20250828",
29548+
version: "19.2.0-native-fb-3fe51c9e-20250829",
2954929549
rendererPackageName: "react-dom",
2955029550
currentDispatcherRef: ReactSharedInternals,
29551-
reconcilerVersion: "19.2.0-native-fb-89a803fc-20250828"
29551+
reconcilerVersion: "19.2.0-native-fb-3fe51c9e-20250829"
2955229552
};
2955329553
internals.overrideHookState = overrideHookState;
2955429554
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -30003,7 +30003,7 @@ __DEV__ &&
3000330003
exports.useFormStatus = function () {
3000430004
return resolveDispatcher().useHostTransitionStatus();
3000530005
};
30006-
exports.version = "19.2.0-native-fb-89a803fc-20250828";
30006+
exports.version = "19.2.0-native-fb-3fe51c9e-20250829";
3000730007
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
3000830008
"function" ===
3000930009
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<69eadb28bd17d1d60cdc2028f0e83764>>
10+
* @generated SignedSource<<a0fccc68b7f5f35b768d30da6a593794>>
1111
*/
1212

1313
/*
@@ -17269,14 +17269,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1726917269
};
1727017270
var isomorphicReactPackageVersion$jscomp$inline_2035 = React.version;
1727117271
if (
17272-
"19.2.0-native-fb-89a803fc-20250828" !==
17272+
"19.2.0-native-fb-3fe51c9e-20250829" !==
1727317273
isomorphicReactPackageVersion$jscomp$inline_2035
1727417274
)
1727517275
throw Error(
1727617276
formatProdErrorMessage(
1727717277
527,
1727817278
isomorphicReactPackageVersion$jscomp$inline_2035,
17279-
"19.2.0-native-fb-89a803fc-20250828"
17279+
"19.2.0-native-fb-3fe51c9e-20250829"
1728017280
)
1728117281
);
1728217282
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17298,10 +17298,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1729817298
};
1729917299
var internals$jscomp$inline_2568 = {
1730017300
bundleType: 0,
17301-
version: "19.2.0-native-fb-89a803fc-20250828",
17301+
version: "19.2.0-native-fb-3fe51c9e-20250829",
1730217302
rendererPackageName: "react-dom",
1730317303
currentDispatcherRef: ReactSharedInternals,
17304-
reconcilerVersion: "19.2.0-native-fb-89a803fc-20250828"
17304+
reconcilerVersion: "19.2.0-native-fb-3fe51c9e-20250829"
1730517305
};
1730617306
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1730717307
var hook$jscomp$inline_2569 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17552,4 +17552,4 @@ exports.useFormState = function (action, initialState, permalink) {
1755217552
exports.useFormStatus = function () {
1755317553
return ReactSharedInternals.H.useHostTransitionStatus();
1755417554
};
17555-
exports.version = "19.2.0-native-fb-89a803fc-20250828";
17555+
exports.version = "19.2.0-native-fb-3fe51c9e-20250829";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<6aad31eecf22cde07868cdb9c2069ab4>>
10+
* @generated SignedSource<<6093e7a1780dd5d036f1bce9a628f145>>
1111
*/
1212

1313
/*
@@ -19283,14 +19283,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1928319283
};
1928419284
var isomorphicReactPackageVersion$jscomp$inline_2286 = React.version;
1928519285
if (
19286-
"19.2.0-native-fb-89a803fc-20250828" !==
19286+
"19.2.0-native-fb-3fe51c9e-20250829" !==
1928719287
isomorphicReactPackageVersion$jscomp$inline_2286
1928819288
)
1928919289
throw Error(
1929019290
formatProdErrorMessage(
1929119291
527,
1929219292
isomorphicReactPackageVersion$jscomp$inline_2286,
19293-
"19.2.0-native-fb-89a803fc-20250828"
19293+
"19.2.0-native-fb-3fe51c9e-20250829"
1929419294
)
1929519295
);
1929619296
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19312,10 +19312,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1931219312
};
1931319313
var internals$jscomp$inline_2293 = {
1931419314
bundleType: 0,
19315-
version: "19.2.0-native-fb-89a803fc-20250828",
19315+
version: "19.2.0-native-fb-3fe51c9e-20250829",
1931619316
rendererPackageName: "react-dom",
1931719317
currentDispatcherRef: ReactSharedInternals,
19318-
reconcilerVersion: "19.2.0-native-fb-89a803fc-20250828",
19318+
reconcilerVersion: "19.2.0-native-fb-3fe51c9e-20250829",
1931919319
getLaneLabelMap: function () {
1932019320
for (
1932119321
var map = new Map(), lane = 1, index$321 = 0;
@@ -19582,7 +19582,7 @@ exports.useFormState = function (action, initialState, permalink) {
1958219582
exports.useFormStatus = function () {
1958319583
return ReactSharedInternals.H.useHostTransitionStatus();
1958419584
};
19585-
exports.version = "19.2.0-native-fb-89a803fc-20250828";
19585+
exports.version = "19.2.0-native-fb-3fe51c9e-20250829";
1958619586
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1958719587
"function" ===
1958819588
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)