Conversation
When Vite HMR fires, React Fast Refresh re-runs all effects. The old code unconditionally created a new socket instance, permanently killing the previous one (ReconnectingWebSocket sets _shouldReconnect=false on close). This broke downstream code holding references to the old socket. Track the previous socketOptions reference to distinguish HMR re-runs (same reference) from real option changes (new reference). On HMR, call socket.reconnect() to preserve identity; on option changes, create a new socket as before. Includes StrictMode-based tests that exercise the HMR code path.
pkg-pr-new publish with no arguments skips the private root package and fails to auto-discover workspace packages, causing a 'No packages' error on every PR. Pass the built package directories explicitly.
Prevent automatic reconnect during HMR/StrictMode when the socket was created with startClosed: true by guarding the reconnect call. use-socket.ts now checks socketOptions.startClosed before calling socket.reconnect(), ensuring the socket stays CLOSED across React double-invokes. Tests in react-hooks.test.tsx were updated to assert the closed readyState for startClosed and to adjust assertions around socket identity and behavior under StrictMode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )