[pull] main from motiondivision:main#201
Merged
Conversation
When passing scale: "0" or similar string values, the buildTransform function was incorrectly treating these as default values because it only checked if parseFloat(value) === 0 for string values. For scale properties, the default is 1, not 0. This fix makes the string branch mirror the number branch logic, checking against 1 for scale properties and 0 for others. Fixes #3465
Apply the same fix to the duplicate buildTransform function in effects/style/transform.ts. This ensures string scale values of "0" are correctly handled in the styleEffect code path as well. Fixes #3465
…bers-li3Qf Handle default transform values when strings
This allows numeric fontSize values to automatically have "px" units appended, matching the behavior of width, height, and other dimension properties. Fixes #2749
…s load When using LazyMotion with async feature loading, state changes that occur before features load (~5ms after mount) would cause the element to snap to its final value instead of animating. This happened because the VisualElement wasn't created until features loaded, so there was no AnimationState to track the state changes. The fix tracks whether the component has already been through React's commit phase before the VisualElement is created. If so, we set manuallyAnimateOnMount to true, which forces the initial animation to run rather than being blocked. Fixes #2759 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The SVG feMorphology filter primitive requires radius to be a unitless number. The radius property was incorrectly mapped to px units, which caused animated radius values to become invalid (e.g., "4px" instead of "4"). Fixes #2779
…dcMtf Fix `radius` in `feMorphology` tag
Fix LazyMotion animation not firing when state changes before features load
…ypes-mudor Add fontSize to default px types list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )