[pull] main from motiondivision:main#189
Merged
Conversation
- Add roundtrip URL parameter to unit-conversion.tsx test for fast animations - Update Cypress test to verify 0 → calc(300px) → 0 animation completes correctly - Remove redundant unit-conversion-var-to-simple.tsx test file - Tests GitHub issue #3410 fix for animating between calc() with CSS vars and simple values 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add comprehensive README documenting projection system architecture, identified performance issues, and potential improvements - Export projection types from framer-motion/projection Key findings documented: - Object pooling is slower than V8 allocation; retain objects on nodes instead - Cumulative scroll/transform caching shows 50-73% improvement potential - Critical per-frame allocation in resolveTargetDelta() with resumingFrom 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add projection system documentation and type exports
- Use DOMMatrix to extract actual translateX value from computed style - More accurate than checking inline style string (which preserves calc expression) - Verifies the animation actually moves the element to the correct position 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Check computed transform matrix for actual translateX position - Verify style.transform preserves calc expression after first animation - Verify style.transform is "none" after animating back to 0 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fixing conversion between css vars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )