[pull] main from motiondivision:main#188
Merged
Conversation
fix: Ensure useMotionValueEvent animationComplete fires for useSpring
Fixing React 19 cleanup when external ref returns cleanup function
In React 19, element.ref was removed and refs are now passed as regular props. This change updates PopChild to check props.ref first (React 19) and fall back to element.ref (React 18) for backwards compatibility. Fixes #3428 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fix React 19 ref compatibility in AnimatePresence popLayout mode
Only initialize the matchMedia listener for prefers-reduced-motion when the reducedMotionConfig is not explicitly set to "never" or "always". This avoids adding unnecessary event listeners when the motion preference is statically configured. Related to: #3304, #2444 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add tests to verify:
- Listener is NOT initialized when reducedMotionConfig is 'never'
- Listener is NOT initialized when reducedMotionConfig is 'always'
- Listener IS initialized when reducedMotionConfig is 'user'
- Default config ('never') does not initialize listener
- Listener is only initialized once across multiple components
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
fix: optimize prefers-reduced-motion listener initialization
Prevents AnimatePresence from processing exit animations multiple times when receiving rapid sequential events (e.g., Radix UI dismissable layers). Adds a Set to track components currently processing exit and guards against duplicate onExit calls. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fix duplicate exit animation processing in AnimatePresence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )