Merged
Conversation
## Summary
- Refactored enqueueLinks limit logging to distinguish between two
scenarios:
- **`enqueueLinks({ limit: X })`**: Now logs once per request handler
call (not once per run), providing feedback each time the limit is hit
in different handlers
- **`maxCrawlDepth`**: Logs once per crawler run, avoiding spam when
multiple handlers trigger the depth limit
- Replaced multiple boolean flags with a cleaner `Set<string>` pattern
for "log once per run" messages
- Added comprehensive tests for both logging behaviors
## Test plan
- [x] Existing tests pass
- [x] New test: `enqueueLinks limit log message should be logged once
per request handler, not once per run`
- [x] New test: `maxCrawlDepth limit log message should only be logged
once per run`
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Closes #3336
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )