Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 32 additions & 16 deletions bun.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions packages/react/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
## [Unreleased]

### Fixed

- **Radio Group, Listbox, Progress, Segment Group**: Fixed group labels rendering orphan label elements; now render as
`span` per W3C ARIA pattern

## [5.32.0] - 2026-02-21

### Added
Expand Down
2 changes: 1 addition & 1 deletion packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
"typescript": "5.9.3",
"vite": "7.3.1",
"vite-plugin-dts": "4.5.4",
"vitest": "^4.0.0",
"vitest": "^4.0.18",
"vitest-axe": "1.0.0-pre.5"
},
"peerDependencies": {
Expand Down
6 changes: 3 additions & 3 deletions packages/react/src/components/listbox/listbox-label.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ import { type HTMLProps, type PolymorphicProps, ark } from '../factory'
import { useListboxContext } from './use-listbox-context'

export interface ListboxLabelBaseProps extends PolymorphicProps {}
export interface ListboxLabelProps extends HTMLProps<'label'>, ListboxLabelBaseProps {}
export interface ListboxLabelProps extends HTMLProps<'span'>, ListboxLabelBaseProps {}

export const ListboxLabel = forwardRef<HTMLLabelElement, ListboxLabelProps>((props, ref) => {
export const ListboxLabel = forwardRef<HTMLSpanElement, ListboxLabelProps>((props, ref) => {
const listbox = useListboxContext()
const mergedProps = mergeProps(listbox.getLabelProps(), props)

return <ark.label {...mergedProps} ref={ref} />
return <ark.span {...mergedProps} ref={ref} />
})

ListboxLabel.displayName = 'ListboxLabel'
2 changes: 1 addition & 1 deletion packages/react/src/components/popover/examples/nested.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const Nested = () => {
<Popover.Description className={styles.Description}>
Manage your preferences and account settings.
</Popover.Description>
<Popover.Root positioning={{ placement: 'right' }}>
<Popover.Root lazyMount unmountOnExit positioning={{ placement: 'right' }}>
<Popover.Trigger className={button.Root}>Advanced</Popover.Trigger>
<Portal>
<Popover.Positioner className={styles.Positioner}>
Expand Down
6 changes: 3 additions & 3 deletions packages/react/src/components/progress/progress-label.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ import { type HTMLProps, type PolymorphicProps, ark } from '../factory'
import { useProgressContext } from './use-progress-context'

export interface ProgressLabelBaseProps extends PolymorphicProps {}
export interface ProgressLabelProps extends HTMLProps<'label'>, ProgressLabelBaseProps {}
export interface ProgressLabelProps extends HTMLProps<'span'>, ProgressLabelBaseProps {}

export const ProgressLabel = forwardRef<HTMLLabelElement, ProgressLabelProps>((props, ref) => {
export const ProgressLabel = forwardRef<HTMLSpanElement, ProgressLabelProps>((props, ref) => {
const progress = useProgressContext()
const mergedProps = mergeProps(progress.getLabelProps(), props)

return <ark.label {...mergedProps} ref={ref} />
return <ark.span {...mergedProps} ref={ref} />
})

ProgressLabel.displayName = 'ProgressLabel'
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ import { type HTMLProps, type PolymorphicProps, ark } from '../factory'
import { useRadioGroupContext } from './use-radio-group-context'

export interface RadioGroupLabelBaseProps extends PolymorphicProps {}
export interface RadioGroupLabelProps extends HTMLProps<'label'>, RadioGroupLabelBaseProps {}
export interface RadioGroupLabelProps extends HTMLProps<'span'>, RadioGroupLabelBaseProps {}

export const RadioGroupLabel = forwardRef<HTMLLabelElement, RadioGroupLabelProps>((props, ref) => {
export const RadioGroupLabel = forwardRef<HTMLSpanElement, RadioGroupLabelProps>((props, ref) => {
const radioGroup = useRadioGroupContext()
const mergedProps = mergeProps(radioGroup.getLabelProps(), props)

return <ark.label {...mergedProps} ref={ref} />
return <ark.span {...mergedProps} ref={ref} />
})

RadioGroupLabel.displayName = 'RadioGroupLabel'
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ import { parts } from './segment-group.anatomy'
import { useSegmentGroupContext } from './use-segment-group-context'

export interface SegmentGroupLabelBaseProps extends PolymorphicProps {}
export interface SegmentGroupLabelProps extends HTMLProps<'label'>, SegmentGroupLabelBaseProps {}
export interface SegmentGroupLabelProps extends HTMLProps<'span'>, SegmentGroupLabelBaseProps {}

export const SegmentGroupLabel = forwardRef<HTMLLabelElement, SegmentGroupLabelProps>((props, ref) => {
export const SegmentGroupLabel = forwardRef<HTMLSpanElement, SegmentGroupLabelProps>((props, ref) => {
const segmentGroup = useSegmentGroupContext()
const mergedProps = mergeProps(segmentGroup.getLabelProps(), parts.label.attrs as Record<string, string>, props)

return <ark.label {...mergedProps} ref={ref} />
return <ark.span {...mergedProps} ref={ref} />
})

SegmentGroupLabel.displayName = 'SegmentGroupLabel'
5 changes: 5 additions & 0 deletions packages/solid/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
## [Unreleased]

### Fixed

- **Radio Group, Listbox, Progress, Segment Group**: Fixed group labels rendering orphan label elements; now render as
`span` per W3C ARIA pattern

## [5.32.0] - 2026-02-21

### Added
Expand Down
2 changes: 1 addition & 1 deletion packages/solid/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
"typescript": "5.9.3",
"vite": "7.3.1",
"vite-plugin-solid": "2.11.10",
"vitest": "^4.0.0",
"vitest": "^4.0.18",
"vitest-axe": "1.0.0-pre.5"
},
"peerDependencies": {
Expand Down
Loading