Repository navigation
perf(extension): idle control overlay and release accessibility mode - #1
Merged
Merged
Conversation
…ssibility mode The control glow animated an inset box-shadow forever, which repaints the whole viewport every frame for the entire session. Paint the glow once and pulse a pre-painted layer's opacity for two cycles at onset (compositor-only), with no pulse under prefers-reduced-motion. Each observe/snapshot enabled the Accessibility domain and never disabled it, so the renderer kept the AX tree live for the rest of the session. Disable it once the capture has read the tree, through the capture's worker pool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-local perf fixes; measurements and
changes.mdland in this PR before merge.prefers-reduced-motion. Upstream animated an insetbox-shadowforever, repainting the viewport every frame.Tests: new
ControlOverlayidle test andaccessibility-release.test.tsfail on upstream3f10983and pass here; extension suite 2421 passed / 4 load-sensitive timing tests that pass when run alone;tsc --noEmitand biome clean.Summary by cubic
Fixes two extension performance issues in the capture path and marks the repo as a fork of
Tencent/BrowserSkill.box-shadowforever; no pulse underprefers-reduced-motion.ControlOverlayidle test andaccessibility-release.test.ts, including a case where the release fails without failing the capture.changes.mdcredit upstreamTencent/BrowserSkill;changes.mddocuments each fix, its measurements, and the post-stop CPU tail finding, for which no code change was made.Written for commit c6385d4. Summary will update on new commits.