Step2 #45
Closed
Step2 #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javajigi
suggested changes
Mar 4, 2019
| RequestMapping requestMapping = new RequestMapping(); | ||
| AbstractController controller = requestMapping.getController(request.getPath()); | ||
|
|
||
| if (request.getMethod() == HttpMethod.GET) { |
There was a problem hiding this comment.
request.isGet()으로 구현할 수 있지 않을까?
| controller.doGet(request, response); | ||
| } | ||
|
|
||
| if (request.getMethod() == HttpMethod.POST) { |
There was a problem hiding this comment.
request.isPost()으로 구현할 수 있지 않을까?
| private boolean login = false; | ||
| private Map<String, String> httpRequest = new HashMap<>(); | ||
|
|
||
| public HttpRequest(InputStream in) throws IOException { |
There was a problem hiding this comment.
이 메소드가 너무 많은 일을 하고 있는 것 아닌가요?
메소드가 한 가지 일만 하도록 리팩토링 해보세요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.