Step2 PR #40
Merged
Step2 PR #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javajigi
suggested changes
Jan 28, 2019
src/main/java/util/IOUtils.java
Outdated
| return true; | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
return matcher.find();로 구현 가능
| @@ -74,7 +75,7 @@ public static void registerGetMethod(Class clazz, Stream<Method> stream) { | |||
| List<Method> getMethods = stream.collect(Collectors.toList()); | |||
| for (Method getMethod : getMethods) { | |||
| GetMapping getMapping = getMethod.getAnnotation(GetMapping.class); | |||
| handlerMapper.put(new Mapping(getMapping.value(), "GET") | |||
| handlerMapper.put(new Mapping(getMapping.value(), MethodType.GET) | |||
| , (body, jSessionId) -> invokeMethod(createAllParameters(body, getMethod, jSessionId), clazz, getMethod)); | |||
| } | |||
There was a problem hiding this comment.
GET과 POST mapping하는 부분을 분리해야 하나?
분리하지 않고 구현할 수 없나?
There was a problem hiding this comment.
Enum, Lambda를 이용해서 구현했습니다. 피드백 부탁드립니다!
피드백 반영
| } | ||
|
|
||
| @Override | ||
| public Class identification() { |
There was a problem hiding this comment.
supportsParameter 메소드를 활용하면 굳이 이 메소드가 필요한가?
There was a problem hiding this comment.
기존의 identification() 메소드가 supportParameter 와 동일한 역할을 수행하기 때문에 identification() 제거 및 supportParameter() 활용하도로 수정
|
|
||
| public class WebMvcConfig { | ||
|
|
||
| private Map<Class, HandlerMethodArgumentResolver> handlerMethodArgumentResolvers; |
There was a problem hiding this comment.
List<HandlerMethodArgumentResolver> handlerMethodArgumentResolvers로 구현할 수 있지 않을까?
There was a problem hiding this comment.
List 구현 완료
- 질문사항 : Map으로 key 값을 통해 접근하는 것이 List 에서 하나씩 조회하는 것보다 빠르다고 생각을 해서
Map으로 구현을 했는데, 리스트로 구현을 해야하는 이유는 무엇이 있을까요?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
코드가 지저분하고, 복잡하다고 생각이 듭니다. 추가적으로 게선해야할 부분이 무엇있을까요?!