Step2 #39
Merged
Step2 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 26, 2019 16:51
// todo HttpResponse 리팩토링하기
javajigi
suggested changes
Jan 28, 2019
|
|
||
| @Override | ||
| public void service(HttpRequest request, HttpResponse response) throws IOException { | ||
| if (request.getMethod().equals(HttpMethod.GET)) |
There was a problem hiding this comment.
request.isGet() 또는 request.matchMethod(HttpMethod.GET)는 어떨까?
|
|
||
| Controller login = DispatchPath.findController(loginPath); | ||
| logger.debug("loginPath : {}", login); | ||
| assertTrue(login instanceof LoginController); |
There was a problem hiding this comment.
테스트 메소드 하나에 너무 많은 경우를 테스트하고 있다.
반복 테스트를 줄이던가 테스트 수를 줄여도 되지 않을까?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAS Step2
Controller interface
인터페이스를 활용하여 컨트롤러의 실행 부분의 중복을 제거하였습니다.
AbstractController클래스AbstractController는doGet(),doPost()메소드를 가지고 있다.DispatchPath enum
path와Controller를 갖는 enum을 만들어 path에 맞는 컨트롤러에 맵핑하는 곳의 중복과 if문을 제거하였습니다.