Step2 구현하기 #36
Merged
Step2 구현하기 #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javajigi
suggested changes
Jan 24, 2019
| @@ -15,40 +15,40 @@ | |||
| public class ParameterBinder { | |||
There was a problem hiding this comment.
Spring의 HandlerMethodArgumentResolver 인터페이스를 참고해 구현해 본다.
javajigi
suggested changes
Jan 25, 2019
| import java.util.stream.Collectors; | ||
|
|
||
| import static org.slf4j.LoggerFactory.getLogger; | ||
|
|
||
| public class ParameterBinder { | ||
| private static final Logger log = getLogger(ParameterBinder.class); | ||
| private static final Map<MethodParameter, HandlerMethodArgumentResolver> parameterBinderHandler = new HashMap<>(); |
There was a problem hiding this comment.
MethodParameter없이 List<HandlerMethodArgumentResolver>로 구현할 수 없을까?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step2에서 제시하는 방법대로 리팩토링을 하고 싶었는데 구조가 다르다보니 똑같이 하진 못했습니다.
최대한 이전 코드에서 리팩토링 해보았습니다.
피드백 많이 부탁드립니다!!