HTTP 웹 서버 2단계 - 리팩토링 #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javajigi
suggested changes
Oct 12, 2018
| import domain.HttpRequest; | ||
| import domain.HttpResponse; | ||
|
|
||
| public class AbstractController implements Controller { |
There was a problem hiding this comment.
AbstractController을 직접 생성하지 못하도록 abstract 클래스로 구현해 본다.
| @Override | ||
| public void service(HttpRequest request, HttpResponse response) { | ||
|
|
||
| } |
There was a problem hiding this comment.
request method에 따라 doGet/doPost로 분기하는 로직이 있어야 하지 않을까?
|
|
||
| } | ||
|
|
||
| public void doGet(HttpRequest request, HttpResponse response) { |
There was a problem hiding this comment.
public이 아니라 protected로 구현
|
|
||
| } | ||
|
|
||
| public void doPost(HttpRequest request, HttpResponse response) { |
There was a problem hiding this comment.
public이 아니라 protected로 구현
| private Socket connection; | ||
| private Map<String, Controller> controllers = new HashMap<>(); |
There was a problem hiding this comment.
이와 같이 구현해도 요청이 올 때마다 매번 Map이 초기화되지 않을까?
Map을 한번 생성한 후 재사용하도록 구현한다.
Map 초기화하는 클래스를 RequestMapping과 같은 별도의 클래스로 분리해 본다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BufferedReader.read()의 목적
charArray를 읽기 위한 것
byteArray를 읽고 싶다면 InputStream, BufferedInputStream을 이용할 것
body가 없다면 header에 content-length가 생기지 않는다.
이번 미션을 덕분에 다시 한 번 인터페이스, 추상클래스를 이용한 객체지향 프로그래밍의 참맛을 다시 느낄 수 있었습니다.
초반에 TDD로 하려고 마음을 먹고 덤벼들었으나 아직 제 실력으로는 테스트하기 힘든 부분들이 있어 TDD를 하지 못한 것이 조금 아쉬웠지만, 리팩토리 잘 한 것으로 만족합니다. 하하.