Gramway framework2 add DI #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javajigi
suggested changes
Jul 30, 2018
src/main/java/model/BeanFactory.java
Outdated
| if (clazz.isAnnotationPresent(Controller.class)) { | ||
| addController(clazz); | ||
| } | ||
| } |
There was a problem hiding this comment.
static으로 구현하기 보다 init()과 같은 메소드를 만들고 호출하는 구조면 어떨까?
src/main/java/model/BeanFactory.java
Outdated
|
|
||
| if (directory.exists()) { | ||
| scan(directory.listFiles(), classes, ROOT); | ||
| } |
There was a problem hiding this comment.
이렇게 수동으로 구현하지 말고 reflections 라이브러리 적용해서 구현해 봐라.
src/main/java/model/BeanFactory.java
Outdated
| public static void addBeans(List<Class<?>> classes) { | ||
| for (Class<?> clazz : classes) { | ||
| addControllerBean(clazz); | ||
| addRepository(clazz); |
There was a problem hiding this comment.
Controller, Repository만이 아니라 추후 Service, Component와 같은 애노테이션도 추가할 수 있도록 확장 가능한 구조로 개선해 보면 어떨까? 애노테이션의 배열을 전달하면 해당 클래스를 모두 찾아 Bean으로 등록..
이후에 inject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DI 에 대해 아직 이해가 부족해 맞는지 잘 모르겠지만 일단 구현해 보았습니다.
@repository 어노테이션을 붙이면 BeanFactory에 해당 인스턴스가 한번만 생성되서 저장이 되고,
@Autowired 어노테이션을 필드에 붙이면 해당 필드 값에 BeanFactory에서 해당 인스턴스를 주입해주는 방식으로 구현하였습니다.