fix(trackcvg): dynamic x-axis label based on residuals header#159
Open
florian-simvia wants to merge 1 commit intocode-saturne:masterfrom
Open
fix(trackcvg): dynamic x-axis label based on residuals header#159florian-simvia wants to merge 1 commit intocode-saturne:masterfrom
florian-simvia wants to merge 1 commit intocode-saturne:masterfrom
Conversation
The x-axis label was hardcoded to "time (s)" for all subplots. When local time stepping is used, residuals are indexed by iteration number, not physical time. This reads the first column of the residuals CSV/DAT header to detect the mode and sets the label per subplot: "Iteration number" for residuals in iteration mode, "Time (s)" otherwise. Probes and profiles always default to "Time (s)".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary :
The x-axis label in trackcvg was hardcoded to
time (s)for all subplots. When local time stepping is used, the first column ofresiduals.csvis iteration, not t, so the label was incorrect.This patch reads the first column of the residuals CSV/DAT header to detect the mode and sets the x-axis label per subplot:
Iteration numberorTime (s)depending on the headerTime (s)Changes:
detectXLabelCsv/detectXLabelDatmethods to detect x-axis type from file headertime (s)in drawFigure with per-subplot labelsupdateViewto assign the correct labelTest:
Tested manually with:
iteration) → displaysIteration numberon residuals subplot,Time (s)on probes subplott) → displaysTime (s)on residuals and probes subplot