Button: use isPending instead of isLoading #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8d1c81f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for obos-grunnmuren ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alexanbj
changed the title
* deprecate isLoading in favor of RAC's isPending * CSS only solution to keep the button width while in a pending state
Co-authored-by: Oscar Carlström <oscar.carlstrom@gmail.com>
oscarcarlstrom
approved these changes
Nov 25, 2024
aulonm
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that when the button is in a pendingstate it can't be interacted with. This means you don't have to disable a button to prevent multiple submissions etc. Note that our Button component also can render a RAC Link, which technically doesn't support isPending. It will render to look the same as a pending button, but interactions won't be disabled. This is a tradeoff we'll have to make..