Skip to content
This repository was archived by the owner on Mar 8, 2024. It is now read-only.

Remove GDPR flag on bricks integrator #146

Merged
merged 8 commits into from
Jun 28, 2023
Merged

Conversation

lumburovskalina
Copy link
Collaborator

@lumburovskalina lumburovskalina commented Jun 22, 2023

PRs:

NOTE:
The active learners currently do not work on the heuristics page, will be fixed as part of bricks: code-kern-ai/bricks#320
NOTE:
https://github.com/code-kern-ai/refinery-ui/pull/146#issuecomment-1610912440 -> will be fixed also as part of bricks

@lumburovskalina lumburovskalina marked this pull request as ready for review June 23, 2023 09:33
@SimonDegrafKern
Copy link
Contributor

SimonDegrafKern commented Jun 27, 2023

Not really GDPR-related, but for me when I stepped into this overview it was striking that the "details" just look like a field and not a header of a group of fields and that there is no space between the parantheses and "source code"
Bildschirmfoto 2023-06-27 um 11 17 15

  • resolved

Lina: For the source code empty space I would agree :)
For the Details header, I would assume that the cursor pointer on "Details" shows that it's clickable and the arrow on the right side, but still maybe we could underline or bold it
I think we can make both 'Details' and 'Source code' underline

Simon:
I see where you you are coming from but for me it just looks like the empty space is missing something. Maybe there can be something like (collapsed) or (click to open) or something like this be put as a placeholder? Or the underlined solution you proposed
image

@SimonDegrafKern
Copy link
Contributor

SimonDegrafKern commented Jun 27, 2023

Again not GDPR related but source code seems to be cut off and I could not (or did not manage to) scroll

Bildschirmfoto 2023-06-27 um 11 19 24

  • resolved

@JWittmeyer
Copy link
Member

JWittmeyer commented Jun 28, 2023

I think there is something wrong here

image

  • resolved

@JWittmeyer
Copy link
Member

JWittmeyer commented Jun 28, 2023

I know we talked about this already but I think there is still some misconception.
image

This error is shown in the record ide when I select an active learner. They shouldn't be selectable in the record ide.

  • resolve

Also since active learner in general currently don't work with the bricks integrator I would have expected a note in the PR description and (if possible) link to the bricks pr that fixes it (discussion with Leo)

Lina: okay, i understood that we shouldn't display them on the attribute calculation page but on record ide and AL they should stay, then the condition you will se in the bricks integrator is wrong.

@lumburovskalina lumburovskalina merged commit c6add0e into dev Jun 28, 2023
@lumburovskalina lumburovskalina deleted the remove-gdpr-bricks branch June 28, 2023 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants