Skip to content

LLM attribute calculation #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 65 commits into from
Feb 13, 2025
Merged

LLM attribute calculation #287

merged 65 commits into from
Feb 13, 2025

Conversation

@lumburovskalina
Copy link
Contributor

lumburovskalina commented Feb 4, 2025

Since this is a Note a suggest that we put into italic

Screenshot 2025-02-04 at 16 00 00
  • resolved
  • ignored

@lumburovskalina
Copy link
Contributor

lumburovskalina commented Feb 4, 2025

If running id field is empty, the button 'Get by running_id' should be disabled
Screenshot 2025-02-04 at 16 01 34

  • resolved

@lumburovskalina
Copy link
Contributor

lumburovskalina commented Feb 4, 2025

In the LLM playground modal, I would suggest that the 'Use current values for attribute' should be disabled if the 'Test configuartion' is still running (since it takes some time)

  • resolved
  • ignored

@lumburovskalina
Copy link
Contributor

lumburovskalina commented Feb 4, 2025

If you try to change the Dropdown 'Load config template' it doesn't display the correct value

Screenshot 2025-02-04 at 16 50 22
  • resolved
  • intended

@lumburovskalina
Copy link
Contributor

lumburovskalina commented Feb 4, 2025

Should we display this in <pre> tag?(to look more like code)

Screenshot 2025-02-04 at 16 53 02
  • resolved
  • ignored

edit @JWittmeyer:
Added for view button display but not in the shorthand display

@lumburovskalina
Copy link
Contributor

lumburovskalina commented Feb 4, 2025

If i create an attribute from different type (ex. Category) and i change the datatype i don't see any of the configuration for the LLM response (only the provider and the api key), and the code is still the same.

We have some logic here that if it's the initial value, so nothing has changes since the creation, the user can still override it,
otherwise it's still possible/clickable but it doesn't make too much sense because the user will loose the data.

In this case we only need the config fields and the code change.

  • resolved

Edit @JWittmeyer
Disabled the option to switch to LLM Type and vice versa since the attribute needs to be created with a different configuration

@lumburovskalina
Copy link
Contributor

lumburovskalina commented Feb 10, 2025

i think the modal can be a bit wider

Screenshot 2025-02-10 at 16 37 17
  • resolved
  • ignored

@lumburovskalina
Copy link
Contributor

lumburovskalina commented Feb 10, 2025

Test configuration and 'Load config template' still possible for usable attributes, i think it should be disabled.

Edit Lina: I noticed that most of the fields are enabled, is that wanted?

  • resolved
  • ignored

Edit Jwittmeyer
Playground removed for useable attributes

@lumburovskalina
Copy link
Contributor

lumburovskalina commented Feb 10, 2025

Cursor pointer on disabled option in dropdown

Screenshot 2025-02-10 at 16 42 30
  • resolved

Edit JWittmeyer
Tooltip cursor overlays. imo best possibility to set to cursor-not-allowed => results in small overleap on edges

Alternative could be cursor default but then the disabled would also be default

@JWittmeyer JWittmeyer merged commit 97816c8 into dev Feb 13, 2025
1 check passed
@JWittmeyer JWittmeyer deleted the llm-ac branch February 13, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants