Skip to content

Extra checks added whie getting absolute file path in FileUtil #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2021
Merged

Extra checks added whie getting absolute file path in FileUtil #94

merged 1 commit into from
Jun 12, 2021

Conversation

danishjamal104
Copy link
Contributor

Fixes #93

Description

  • Extra checks added when accessing the file absolute path.
  • Removed the sd card path check in the path from /document.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Build the project with ./gradlew build to make sure you didn't break anything
  • Added the comments particularly in hard-to-understand areas
  • In case of multiple commits please squash them

@danishjamal104 danishjamal104 added bug fixed Bug has been fixed ✅ app crash fixed This fixes App Crash 🌟 priority fix Priority issue has been fixed labels Jun 11, 2021
@danishjamal104 danishjamal104 merged commit 6850d9f into code-gambit:dev Jun 12, 2021
@danishjamal104 danishjamal104 deleted the fix-93 branch June 12, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lakshya-20 lakshya-20 Awaiting requested review from lakshya-20

@ayush0x00 ayush0x00 Awaiting requested review from ayush0x00

Assignees
No one assigned
Labels
bug fixed Bug has been fixed 🌟 priority fix Priority issue has been fixed ✅ app crash fixed This fixes App Crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] app crash while uploading file using document option
1 participant
@danishjamal104