Open
Conversation
Contributor
hannahbergam
left a comment
There was a problem hiding this comment.
I'd still like to use the enter/esc paradigm here so a user doesn't have to tab through all console logs if they're trying to navigate elsewhere!
8 tasks
Contributor
Author
Sounds good! Will update and also log a ticket for the current regression in Enter/Escape in the chat workspace. |
Contributor
Yay thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds keyboard navigability to console logs in the Web Lab 2 console panel. It also passes a custom icon for the log with
aria-hidden: trueso that the VoiceOver ignores this decorative icon and reads the message text. If this is not included, the log message is not read out load and instead VO says 'and two more items'.We should probably update the
Alertcomponent so that it accepts aniconAriaHidden. I added that as a TODO in the comment.Before update
before-update-console.mov
After update
after-update-console.mov
Links
Testing story
Tested locally on
weblab2levels with Mac Voiceover.Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Creation Checklist: