Skip to content

Conversation

@drizco
Copy link
Contributor

@drizco drizco commented Oct 24, 2025

while investigating a robo DTL failure where the response logged in slack was from the github api indicating an invalid head property, I realized the error handling in create_pull_request was somehow allowing the execution to get that far, but had to be failing silently earlier, likely in create_branch_from_commit.

Screenshot 2025-10-24 at 1 49 31 PM

create_branch_from_commit does more than just create the branch, it also merges in the last green test commit and pushes that branch to origin. I could see that the branch was created successfully, but I suspect it was never pushed to origin, causing the github api error because it couldn't find the head branch we specified. I think it's possible the merge failed but did not result in any conflicts, which is what was being checked before. in this pr, I added exceptions for specific steps rather than returning a boolean up to the caller to raise a generic exception.

Links

  • Jira:

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Creation Checklist:

  • Tests provide adequate coverage
  • Privacy impacts have been documented
  • Security impacts have been documented
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Follow-up work items (including potential tech debt) are tracked and linked

@drizco drizco force-pushed the ryan/fix/improve-error-handling-in-deploy-to-levelbuilder branch from 4e7d52c to ef79229 Compare October 24, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant