fix(levelbuilder): improve error handling in deploy to levelbuilder #69072
+18
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while investigating a robo DTL failure where the response logged in slack was from the github api indicating an invalid
headproperty, I realized the error handling increate_pull_requestwas somehow allowing the execution to get that far, but had to be failing silently earlier, likely increate_branch_from_commit.create_branch_from_commitdoes more than just create the branch, it also merges in the last green test commit and pushes that branch to origin. I could see that the branch was created successfully, but I suspect it was never pushed to origin, causing the github api error because it couldn't find theheadbranch we specified. I think it's possible the merge failed but did not result in any conflicts, which is what was being checked before. in this pr, I added exceptions for specific steps rather than returning a boolean up to the caller to raise a generic exception.Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Creation Checklist: