Fix flaky signing_in ui test

[alex-m-brown]

The iPhone test Scenario: Student sign in from code.org flaked on Tue 3/18/25 with unexpected token at 'dbf54315b9544c8e19aa2305' (JSON::ParserError). It seems like a rather common error with iPhone tests that are often caught on retries (example).

After running this test locally over a dozen times, I have been unable to repro. In order to reduce the chances of this test flaking in the future, I added a new step that retries clicking the sign-in button.

Links

• Jira: P20-1441

Testing story

Verified the changes don't affect a successful test run. Unable to repro the initial issue that caused the flake.

Follow-up work

I will watch the DTT for a while to see how this test does and if it flakes again.

[nicklathe]

I haven't written many UI tests, but this seems like a reasonable fix to me 👍

[artem-vavilov]

I believe a single retry should be sufficient in this case:

Suggested change

	And I click the sign-in button to load a new page
	And I press the first "#signin-button" element to load a new page

code-dot-org/dashboard/test/ui/features/step_definitions/steps.rb

Lines 455 to 466 in 8a80969

	When /^I press the first "([^"]*)" element(?: to load a new (page|tab))?$/ do |selector, load|
	wait_short_until do
	@element = @browser.find_element(:css, selector)
	end
	page_load(load) do
	@element.click
	rescue
	# Single retry to compensate for element changing between find and click
	@element = @browser.find_element(:css, selector)
	@element.click
	end
	end