Skip to content

Small python lab theming updates #66068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

molly-moen
Copy link
Contributor

A couple small theming things I missed in Python Lab:

  • Theme the project picker modal
  • Use the correct button color for the validate button

Screenshots

Validate button before (light mode)

Dark mode is unchanged

Screenshot 2025-05-22 at 3 22 58 PM

Validate button after (light mode)

Screenshot 2025-05-22 at 3 21 26 PM

Project Picker

Dark mode is unchanged.
Screenshot 2025-05-22 at 3 21 03 PM

Testing story

Tested locally.

Follow-up work

I'm still not sure what color the project switcher button should be in the workspace header. I started a slack thread and will follow up if we want to change it (right now it's black in light mode, which looks a little jarring).

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@molly-moen molly-moen requested a review from a team May 22, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant