Skip to content

Track member approval #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Track member approval #1307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/code_corps/analytics/in_memory_api.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,14 @@ defmodule CodeCorps.Analytics.InMemoryAPI do

def identify(user_id, _traits), do: log_identify(user_id)

def track(user_id, event_name, _properties), do: log_track(user_id, event_name)
def track(user_id, event_name, properties), do: log_track(user_id, event_name, properties)

defp log_identify(user_id) do
Logger.info "Called identify for User #{user_id}"
end

defp log_track(user_id, event_name) do
Logger.info "Called track for event #{event_name} for User #{user_id}"
defp log_track(user_id, event_name, properties) do
props = Poison.encode!(properties)
Logger.info "Called track for event #{event_name} for User #{user_id} and properties #{props}"
Copy link
Contributor

@joshsmith joshsmith Dec 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call logging the properties.

end
end
6 changes: 4 additions & 2 deletions lib/code_corps/analytics/segment_traits_builder.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,12 @@ defmodule CodeCorps.Analytics.SegmentTraitsBuilder do
}
end
defp traits(%CodeCorps.ProjectUser{} = record) do
record = record |> Repo.preload(:project)
record = record |> Repo.preload([:project, :user])
%{
project: record.project.title,
project_id: record.project_id
project_id: record.project_id,
member: record.user.username,
member_id: record.user.id
}
end
defp traits(%CodeCorps.StripeConnectAccount{} = account) do
Expand Down
8 changes: 6 additions & 2 deletions test/lib/code_corps_web/controllers/project_user_controller_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ defmodule CodeCorpsWeb.ProjectUserControllerTest do

tracking_properties = %{
project: project.title,
project_id: project.id
project_id: project.id,
member: user.username,
member_id: user.id
}

assert_received {:track, ^user_id, "Requested Project Membership", ^tracking_properties}
Expand Down Expand Up @@ -106,7 +108,9 @@ defmodule CodeCorpsWeb.ProjectUserControllerTest do

tracking_properties = %{
project: project.title,
project_id: project.id
project_id: project.id,
member: record.user.username,
member_id: record.user.id
}

assert_received {:track, ^user_id, "Approved Project Membership", ^tracking_properties}
Expand Down