Switch ProjectApprovedEmail to SparkPost

Author: begedin

lib/code_corps/emails/project_approved_email.ex

@@ -6,7 +6,7 @@ defmodule CodeCorps.Projects do
   import CodeCorpsWeb.ProjectController, only: [preload: 1]
 
   alias CodeCorps.{
-    Analytics.SegmentTracker, Emails, Mailer, Project, Repo, SparkPost, User
+    Analytics.SegmentTracker, Project, Repo, SparkPost, User
   }
   alias Ecto.Changeset
 
@@ -100,7 +100,6 @@ defmodule CodeCorps.Projects do
   defp send_approved_email(project) do
     project
     |> preload()
-    |> Emails.ProjectApprovedEmail.create()
-    |> Mailer.deliver_now()
+    |> SparkPost.send_project_approved_email()
   end
 end

lib/code_corps/projects/projects.ex

@@ -19,6 +19,10 @@ defmodule CodeCorps.SparkPost.Emails do
     project |> Emails.ProjectApprovalRequest.build |> API.send_transmission
   end
 
+  def send_project_approved_email(project) do
+    project |> Emails.ProjectApproved.build |> API.send_transmission
+  end
+
   def send_receipt_email(charge, invoice) do
     case charge |> Emails.Receipt.build(invoice) do
       %SparkPost.Transmission{} = transmission ->

lib/code_corps/sparkpost/emails/emails.ex

@@ -0,0 +1,44 @@
+defmodule CodeCorps.SparkPost.Emails.ProjectApproved do
+  import Ecto.Query
+
+  alias SparkPost.{Content, Transmission}
+  alias CodeCorps.{
+    Project, ProjectUser, Repo, SparkPost.Emails.Recipient, User, WebClient
+  }
+
+  @spec build(Project.t) :: %Transmission{}
+  def build(%Project{} = project) do
+    %Transmission{
+      content: %Content.TemplateRef{template_id: "project-approval-request"},
+      options: %Transmission.Options{inline_css: true},
+      recipients: project |> get_owners() |> Enum.map(&Recipient.build/1),
+      substitution_data: %{
+        from_name: "Code Corps",
+        from_email: "team@codecorps.org",
+        project_title: project.title,
+        project_url: project |> preload() |> project_url(),
+        subject: "#{project.title} is approved!"
+      }
+    }
+  end
+
+  @spec preload(Project.t) :: Project.t
+  defp preload(%Project{} = project), do: project |> Repo.preload(:organization)
+
+  @spec project_url(Project.t) :: String.t
+  defp project_url(project) do
+    WebClient.url()
+    |> URI.merge(project.organization.slug <> "/" <> project.slug)
+    |> URI.to_string()
+  end
+
+  @spec get_owners(Project.t) :: list(User.t)
+  defp get_owners(%Project{id: project_id}) do
+    query = from u in User,
+      join: pu in ProjectUser, on: u.id == pu.user_id,
+      where: pu.project_id == ^project_id,
+      where: pu.role == "owner"
+
+    query |> Repo.all()
+  end
+end

lib/code_corps/sparkpost/emails/project_approved.ex

@@ -8,6 +8,7 @@ defmodule CodeCorps.SparkPost do
   defdelegate send_message_initiated_by_project_email(message, conversation), to: Emails
   defdelegate send_organization_invite_email(invite), to: Emails
   defdelegate send_project_approval_request_email(project), to: Emails
+  defdelegate send_project_approved_email(project), to: Emails
   defdelegate send_receipt_email(charge, invoice), to: Emails
   defdelegate send_reply_to_conversation_email(part, user), to: Emails
 end

lib/code_corps/sparkpost/sparkpost.ex

@@ -0,0 +1,39 @@
+defmodule CodeCorps.SparkPost.Emails.ProjectApprovedTest do
+  use CodeCorps.DbAccessCase
+
+  alias CodeCorps.SparkPost.Emails.ProjectApproved
+
+  describe "build/1" do
+    test "provides substitution data for all keys used by template" do
+      project = insert(:project)
+
+      %{substitution_data: data} = ProjectApproved.build(project)
+
+      expected_keys =
+        "project-approved"
+        |> CodeCorps.SparkPostHelpers.get_keys_used_by_template
+      assert data |> Map.keys == expected_keys
+    end
+
+    test "builds correct transmission model" do
+      project = insert(:project)
+      %{user: owner_1} = insert(:project_user, project: project, role: "owner")
+      %{user: owner_2} = insert(:project_user, project: project, role: "owner")
+
+      %{substitution_data: data, recipients: [recipient_1, recipient_2]} =
+        ProjectApproved.build(project)
+
+      assert data.from_name == "Code Corps"
+      assert data.from_email == "team@codecorps.org"
+
+      assert data.project_title == project.title
+      assert data.project_url == "http://localhost:4200/#{project.organization.slug}/#{project.slug}"
+      assert data.subject == "#{project.title} is approved!"
+
+      assert recipient_1.address.email == owner_1.email
+      assert recipient_1.address.name == owner_1.first_name
+      assert recipient_2.address.email == owner_2.email
+      assert recipient_2.address.name == owner_2.first_name
+    end
+  end
+end

test/lib/code_corps/emails/project_approved_email_test.exs

@@ -2,9 +2,10 @@ defmodule CodeCorpsWeb.ProjectControllerTest do
   @moduledoc false
 
   use CodeCorpsWeb.ApiCase, resource_name: :project
-  use Bamboo.Test
 
-  alias CodeCorps.{Analytics.SegmentTraitsBuilder, Emails, Project, Repo}
+  alias CodeCorps.{
+    Analytics.SegmentTraitsBuilder, SparkPost.Emails, Project, Repo
+  }
 
   @valid_attrs %{
     cloudinary_public_id: "foo123",
@@ -148,7 +149,7 @@ defmodule CodeCorpsWeb.ProjectControllerTest do
 
       email =
         project
-        |> CodeCorps.SparkPost.Emails.ProjectApprovalRequest.build()
+        |> Emails.ProjectApprovalRequest.build()
 
       assert_received ^email
 
@@ -172,9 +173,9 @@ defmodule CodeCorpsWeb.ProjectControllerTest do
 
       email =
         project
-        |> Emails.ProjectApprovedEmail.create()
+        |> Emails.ProjectApproved.build()
 
-      assert_delivered_email(email)
+      assert_received ^email
 
       user_id = current_user.id
       traits = project |> SegmentTraitsBuilder.build