Switch ProjectApprovalRequest email to SparkPost

Author: begedin

lib/code_corps/emails/project_approval_request_email.ex

@@ -6,7 +6,7 @@ defmodule CodeCorps.Projects do
   import CodeCorpsWeb.ProjectController, only: [preload: 1]
 
   alias CodeCorps.{
-    Analytics.SegmentTracker, Emails, Mailer, Project, Repo, User
+    Analytics.SegmentTracker, Emails, Mailer, Project, Repo, SparkPost, User
   }
   alias Ecto.Changeset
 
@@ -81,12 +81,11 @@ defmodule CodeCorps.Projects do
   end
   defp maybe_send_approval_request_email(%Project{}, %Project{}), do: :nothing
 
-  @spec send_approval_request_email(Project.t) :: Bamboo.Email.t
+  @spec send_approval_request_email(Project.t) :: tuple
   defp send_approval_request_email(project) do
     project
     |> preload()
-    |> Emails.ProjectApprovalRequestEmail.create()
-    |> Mailer.deliver_now()
+    |> SparkPost.send_project_approval_request_email()
   end
 
   @spec maybe_send_approved_email(Project.t, Project.t) :: any

lib/code_corps/projects/projects.ex

@@ -15,6 +15,10 @@ defmodule CodeCorps.SparkPost.Emails do
     invite |> Emails.OrganizationInvite.build |> API.send_transmission
   end
 
+  def send_project_approval_request_email(project) do
+    project |> Emails.ProjectApprovalRequest.build |> API.send_transmission
+  end
+
   def send_receipt_email(charge, invoice) do
     case charge |> Emails.Receipt.build(invoice) do
       %SparkPost.Transmission{} = transmission ->

lib/code_corps/sparkpost/emails/emails.ex

@@ -0,0 +1,56 @@
+defmodule CodeCorps.SparkPost.Emails.ProjectApprovalRequest do
+  import Ecto.Query, only: [where: 3]
+
+  alias SparkPost.{Content, Transmission}
+  alias CodeCorps.{
+    Presenters.ImagePresenter,
+    Project,
+    Repo,
+    SparkPost.Emails.Recipient,
+    User,
+    WebClient
+  }
+
+  @spec build(Project.t) :: %Transmission{}
+  def build(%Project{} = project) do
+    %Transmission{
+      content: %Content.TemplateRef{template_id: "project-approval-request"},
+      options: %Transmission.Options{inline_css: true},
+      recipients: get_site_admins() |> Enum.map(&Recipient.build/1),
+      substitution_data: %{
+        admin_project_show_url: project |> admin_url(),
+        from_name: "Code Corps",
+        from_email: "team@codecorps.org",
+        project_description: project.description,
+        project_logo_url: ImagePresenter.large(project),
+        project_title: project.title,
+        project_url: project |> preload() |> project_url(),
+        subject: "#{project.title} is asking to be approved"
+      }
+    }
+  end
+
+  @spec preload(Project.t) :: Project.t
+  defp preload(%Project{} = project), do: project |> Repo.preload(:organization)
+
+  @spec admin_url(Project.t) :: String.t
+  defp admin_url(project) do
+    WebClient.url()
+    |> URI.merge("/admin/projects/" <> Integer.to_string(project.id))
+    |> URI.to_string()
+  end
+
+  @spec project_url(Project.t) :: String.t
+  defp project_url(project) do
+    WebClient.url()
+    |> URI.merge(project.organization.slug <> "/" <> project.slug)
+    |> URI.to_string()
+  end
+
+  @spec get_site_admins() :: list(User.t)
+  defp get_site_admins() do
+    User
+    |> where([object], object.admin == true)
+    |> Repo.all()
+  end
+end

lib/code_corps/sparkpost/emails/project_approval_request.ex

@@ -7,6 +7,7 @@ defmodule CodeCorps.SparkPost do
   defdelegate send_forgot_password_email(user, token), to: Emails
   defdelegate send_message_initiated_by_project_email(message, conversation), to: Emails
   defdelegate send_organization_invite_email(invite), to: Emails
+  defdelegate send_project_approval_request_email(project), to: Emails
   defdelegate send_receipt_email(charge, invoice), to: Emails
   defdelegate send_reply_to_conversation_email(part, user), to: Emails
 end

lib/code_corps/sparkpost/sparkpost.ex

@@ -0,0 +1,43 @@
+defmodule CodeCorps.SparkPost.Emails.ProjectApprovalRequestTest do
+  use CodeCorps.DbAccessCase
+
+  alias CodeCorps.SparkPost.Emails.ProjectApprovalRequest
+
+  describe "build/1" do
+    test "provides substitution data for all keys used by template" do
+      project = insert(:project)
+      insert(:user, admin: true)
+
+      %{substitution_data: data} = ProjectApprovalRequest.build(project)
+
+      expected_keys =
+        "project-approval-request"
+        |> CodeCorps.SparkPostHelpers.get_keys_used_by_template
+      assert data |> Map.keys == expected_keys
+    end
+
+    test "builds correct transmission model" do
+      project = insert(:project)
+      admin_1 = insert(:user, admin: true)
+      admin_2 = insert(:user, admin: true)
+
+      %{substitution_data: data, recipients: [recipient_1, recipient_2]} =
+        ProjectApprovalRequest.build(project)
+
+      assert data.from_name == "Code Corps"
+      assert data.from_email == "team@codecorps.org"
+
+      assert data.admin_project_show_url == "http://localhost:4200/admin/projects/#{project.id}"
+      assert data.project_description == project.description
+      assert data.project_logo_url == "#{Application.get_env(:code_corps, :asset_host)}/icons/project_default_large_.png"
+      assert data.project_title == project.title
+      assert data.project_url == "http://localhost:4200/#{project.organization.slug}/#{project.slug}"
+      assert data.subject == "#{project.title} is asking to be approved"
+
+      assert recipient_1.address.email == admin_1.email
+      assert recipient_1.address.name == admin_1.first_name
+      assert recipient_2.address.email == admin_2.email
+      assert recipient_2.address.name == admin_2.first_name
+    end
+  end
+end

test/lib/code_corps/emails/project_approval_request_email_test.exs

@@ -148,9 +148,9 @@ defmodule CodeCorpsWeb.ProjectControllerTest do
 
       email =
         project
-        |> Emails.ProjectApprovalRequestEmail.create()
+        |> CodeCorps.SparkPost.Emails.ProjectApprovalRequest.build()
 
-      assert_delivered_email(email)
+      assert_received ^email
 
       user_id = current_user.id
       traits = project |> SegmentTraitsBuilder.build