Add traversePostOrderNAry TypeScript goody#388
Merged
Conversation
miorel
force-pushed
the
traverse-post-order-nary
branch
from
3878338 to
f1a4c8c
Compare
elimanzo
approved these changes
Aug 26, 2024
Contributor
elimanzo
left a comment
elimanzo
left a comment
There was a problem hiding this comment.
Looks good. Was this inspo from today's POTD 😄
|
|
||
| function* traverseLevelOrder(root) { | ||
| if (!root) { | ||
| if (root == null) { |
Contributor
There was a problem hiding this comment.
Quick question why the preference from !root vs root == null Is this to be more specific since !variable checks for any falsy values?
Contributor
Author
There was a problem hiding this comment.
I've gone back and forth on this one. == null is more explicit, !root is more concise... Either one could be something to optimize for in library code. Today I'm feeling more explicit 😄
Contributor
Author
|
Yep, inspired by the PotD indeed! |
This was referenced Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on LeetCode: https://leetcode.com/problems/n-ary-tree-postorder-traversal/submissions/1368487878/