Add tests for getLines utility#365
Merged
miorel merged 5 commits intocode-chronicles-code:mainfrom Aug 24, 2024
Merged
Conversation
making it take into account other new line characters
miorel
reviewed
Aug 21, 2024
|
|
||
| import { getLines } from "../getLines"; | ||
|
|
||
| describe("chunkBySize", () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| describe("chunkBySize", () => { | |
| describe("getLines", () => { |
workspaces/util/src/getLines.ts
Outdated
| export function* getLines(text: string): Generator<string, void, void> { | ||
| for (const [line] of text.matchAll(/[^\n]+\n?|\n/g)) { | ||
| for (const [line] of text.matchAll( | ||
| /[^\n\v\f\r]+(\n|\r|\v|\f)?|(\n|\r|\v|\f)/g, |
Contributor
There was a problem hiding this comment.
Hey, thanks for thinking about different kinds of new lines. I think this is actually not entirely correct, because it won't do the right thing for Windows. On Windows new lines are usually not just one character, but two, specifically "\r\n". So "hello\r\nworld\r\n" is two lines, but I think this regex will break it into "hello\r", "\n", "world\r", and "\n" when we just wanted "hello\r\n" and "world\r\n". It might even be nice to have a test case testing exactly this.
Let's stick to only handling \n for now, using the old regex. If a need arises to handle other kinds of new lines, we can update it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #325