Skip to content

Fix broken test in GitHubEventSpec #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 29, 2020

Conversation

ashawley
Copy link
Contributor

In the change in #97, I should have changed the test. I assumed the compiler would fail to typecheck and compile if something in the test suite needed to be updated, but the ScalaTest matcher used is for Any type.

> testOnly codecheck.github.events.GitHubEventSpec
[error] Some(Repository) was not an instance of Repository, but an
[error] instance of scala.Some

ashawley added 2 commits July 15, 2019 22:37
> testOnly codecheck.github.events.GitHubEventSpec
[error] Some(Repository) was not an instance of Repository, but an
[error] instance of scala.Some
@ashawley ashawley force-pushed the fix-githubevent-test branch from 1f1bcde to 18f311a Compare July 16, 2019 02:53
@shunjikonishi shunjikonishi merged commit 5e96d27 into code-check:master Feb 29, 2020
@ashawley ashawley deleted the fix-githubevent-test branch March 2, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants