-
-
Notifications
You must be signed in to change notification settings - Fork 752
Hide AI summary in all videos & "Display:none;"-conversation #2978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
wbalbo
wants to merge
2
commits into
code-charity:master
Choose a base branch
from
wbalbo:feat-hide-ai-summary
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you! @wbalbo CSS display:none should be enough. So ytd-expandable-metadata-renderer[has-video-summary] it is? if await, for extension storage or our improvedtube.storage is necessary(?), then we should care for the whole extension at once. |
The current version doesn't work, I tried and tested with CSS only, we need the JS part. The await is because I was trying to change it in real time, but it didn't work, and I didn't remove the async await part. I just removed and tested without it, and it worked fine. |
|
CSS should work persistently since the selector doesn't change: unlike our broken playlist button injections, since the whole DOM elements might exist twice.
i see! 👍 (could be good /just reminds me to check anyways 😃 https://github.com/search?q=repo%3Acode-charity%2Fyoutube+storage-loaded&type=code ) |
But this "ytd-engagement-panel-section-list-renderer" is not the correct one for the AI Summary. The correct is the selector that I used on the JS file, "ytd-expandable-metadata-renderer" |
|
yes, my copy paste failed fc3e7f2 |
|
I didn't test using CSS, but I guess should work? I used to use JS because of the toggle option, but I don't mind if you make it work on CSS and remove all the JS part. |
|
@wbalbo the html root element attributes are synced with our toggles: youtube/js&css/extension/core.js Lines 266 to 285 in fc3e7f2
Which is convenient and efficient. ( Themes: youtube/js&css/extension/www.youtube.com/styles.css Lines 736 to 2100 in fc3e7f2
youtube/js&css/web-accessible/www.youtube.com/themes.js Lines 32 to 88 in fc3e7f2
) |
ImprovedTube
added
the
Knowledge Base / Documentation for contributors
Will see soon. I tested your CSS selector with our dark mode* extension. you see it in the bottom here https://github.com/code-charity/crowd-fixes?tab=readme-ov-file#testing-methods (linked form here https://github.com/code-charity/youtube?tab=readme-ov-file#-vision-for-open-source-efficiency--auto-contributors) ..* Dark mode easily found 20000 user (despite it is confusing currently, many leave. it does have uniquely thought-through specificity beyond dark reader. But in the end the author quit at more of an alpha release. The main-switch functionality is confusing or flawed. Back then he also added something obviously relaxing, that i suggested back then, to make any page start fading in from a dark/er background - Instead of the browser flashing full white at us up to every click - but i didn't start using it yet. i think it would need some tuning / settings. ) But more importantly please have a look at the old vision of history manager https://chromewebstore.google.com/detail/history-manager/odognhgojidbcgconbcipmgffjcmfaoj there is so much we could add. ( empowering/meaningful self data management projects also can get various funding. ) - An inspiration also can be FastestSearch (requires palemoon or old firefox with https://github.com/JustOff/ca-archive ) and the Auto Text Pattern selector linked here code-charity/ultimate-REGEX-extension#4 Our extensions share satus.js. For current separation and raising developer motivation, I moved some "global extension ideas" here: code-charity/Wish-Factory#17 and converted them to discussions, just so it could provide list ordered by votes like reddit🙈 - Yet ImprovedTube will need to to trigger permissions dialog once too and offer to run on all pages and #1881 and i guess i would rather organize the ultimate extension framework, combining all said here, than too many separate / abandoned ones? (yet youtube alone makes a high percentage (50%?) of all time people spend with their web browsers.) (hope this "random massage" / perspective is bookmark-worthy or something) |
|
Yeah, they're worth it for sure. I guess the ideas from Wish Factory should be implemented once we have enough votes/people interested. And yes, there are a lot of things to add, maybe we should have something like a "To-Do" list in a specific place? I guess we can use the Projects tab to better organize? Never used, so just a guess. Always happy to help in my free time. |
maybe in that hidden spot not even a perfect to-do list would have many votes yet? (with the most global features saving the most time and the most easy to implement and understand combined). Yet could be pro-active step by step, we could invite our users to watch what matters. Hope to find and or hire a bit of a team. About 5 billion people have been online for more than 5 years. |
ImprovedTube
added
the
Structures (UX & ORG & Teamwork)
ImprovedTube
changed the title
|
PART-2: #2983 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Knowledge Base / Documentation for contributors
We should repurpose this for future reference / Wiki / Education / Introduction
Structures (UX & ORG & Teamwork)
Let's focus on structure! Everything should be as easily seen/found as it is relevant.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve the issues #2901, #2645, and #2966
Tested on Chrome and Edge.