(content categorization /filtering by keywords (regex), starting with:) permanent speed-up "speed-watching"

[Eyevou]

I normally have playback speed set to 2x and have recently, within the past two days, started seeing the addon not always set the value. I went into settings and checked (force even for music) and it's now setting correctly. The playback speed was not being applied to NORMAL videos that had nothing to do with the Music category.

Turning the (force even for music) setting on fixed the playback speed for all normal videos. Seems like something isn't checking correctly.

---

also: #1776

[ImprovedTube]

hi! so it has not been a week?
thanks! #1750

[Eyevou]

I only started noticing it since resetting my browser, which I did 3 days ago. I then did some testing to be sure it wasn't just a music category thing, set Force even with music. Thought about it yesterday and posted about it today.

It could very well have been around for longer than that.

Sorry for not noticing #1750

feel free to merge, delete, or close this ticket. 😄

[ImprovedTube]

thanks, can you tell if the moments or the videos had anything in common, or check again?

( i guess you already tried v4.335 and it is not exactly only after starting your browser ( like #1750 ) and you didnt enable Don't speed up the (rare) category: Education either )

• guess you would have mentioned if you watch a lot about music that is not music or anything,
  however here is how the music-detection works now:
  • By default nearly the whole category "music" (~1/5th of youtube)
    • unless rarely when a word like 'interview' or 'backstage' is in title or tags and it also wont have a duration very common for a song.
  • Additionally terms like "official video" & "sing along" are considered music, if they come in a normal song duration.
  • Additionally we consider music, that YouTube mentiones below the video descriptions, if the duration is reasonable for a song or the amount of songs. - However this check is last and can take long, because videos might start seconds before descriptions appear, so in this last case the music might be detected late by those seconds (if it is not already in the category music etc.)

  • youtube/js&css/web-accessible/www.youtube.com/player.js

    Lines 77 to 118 in a48a2f0

    	// Data:
    	let category = document.querySelector('meta[itemprop=genre]')?.content || false;
    	if (this.storage.player_dont_speed_education === true && category === 'Education') {return;}
    	if (this.storage.player_force_speed_on_music === true) {return;}
    	let titleAndKeywords = document.getElementsByTagName('meta')?.title?.content + " " + document.getElementsByTagName('meta')?.keywords?.content || false;
    	let musicRegexMatch = /official (music )?video|lyrics|cover[\)\]]|[\(\[]cover|cover version|karaok|(sing|play)[- ]?along|卡拉OK|卡拉OK|الكاريوكي|караоке|カラオケ|노래방/i.test(titleAndKeywords) || false;
    	let notMusicRegexMatch = /do[ck]u|interv[iyj]|back[- ]?stage|インタビュー|entrevista|面试|面試|회견|wawancara|مقابلة|интервью|entretien|기록한 것|记录|記錄|ドキュメンタリ|وثائقي|документальный/i.test(titleAndKeywords) || false; // (Tags/keywords shouldnt lie & very few songs titles might have these words)
    	let duration = document.querySelector('meta[itemprop=duration]')?.content || false; // Example: PT1H20M30S
    	function parseDuration(duration) { const [_, h = 0, m = 0, s = 0] = duration.match(/PT(?:(\d+)?H)?(?:(\d+)?M)?(\d+)?S?/).map(part => parseInt(part) || 0);
    	return h * 3600 + m * 60 + s; }
    	let durationInSeconds = parseDuration(duration);
    	function testSongDuration(s) {
    	if (135 <= s && s <= 260) {return 'veryCommon';}
    	if (105 <= s && s <= 420) {return 'common';}
    	if (420 <= s && s <= 720) {return 'long';}
    	if (45 <= s && s <= 105) {return 'short';}
    	let musicSectionLength = document.querySelector('div#items[class*="music-section"]')?.children?.length;
    	if (musicSectionLength && (85 <= s / musicSectionLength && s / musicSectionLength<= 355)) {return 'multiple';}
    	}
    	let songDurationType = testSongDuration(durationInSeconds);
    	// check if the video is PROBABLY MUSIC:
    	if ( ( category === 'Music' && (!notMusicRegexMatch || songDurationType === 'veryCommon'))
    	|| ( musicRegexMatch && typeof songDurationType !== 'undefined' && !notMusicRegexMatch )
    	|| ( category === 'Music' && musicRegexMatch && typeof songDurationType !== 'undefined'
    	|| (/album|Álbum|专辑|專輯|एलबम|البوم|アルバム|альбом|앨범/i.test(titleAndKeywords)
    	&& 1150 <= durationInSeconds && durationInSeconds <= 5000)
    	)
    	// || location.href.indexOf('music.') !== -1 // (=currently we are only running on www.youtube.com anyways)
    	) { } //music player.setPlaybackRate(1); video.playbackRate = 1;
    	else { player.setPlaybackRate(Number(option)); video.playbackRate = Number(option); // #1729 question2
    	// Now this video might rarely be music
    	// - however we can make extra-sure after waiting for the video descripion to load... (#1539)
    	var tries = 0; var intervalMs = 150; if (location.href.indexOf('/watch?') !== -1) {var maxTries = 10;} else {var maxTries = 1;}
    	// ...except when it is an embedded player?
    	var waitForDescription = setInterval(() => {
    	if (document.querySelector('div#description') || (++tries >= maxTries) ) {
    	if (document.querySelector('h3#title[class*="music-section"]') // indicates buyable/registered music
    	&& typeof testSongDuration(parseDuration(document.querySelector('meta[itemprop=duration]')?.content)) !== 'undefined' ) // resonable duration
    	{player.setPlaybackRate(1); video.playbackRate = 1; clearInterval(waitForDescription);}}

[Eyevou]

I hadn't tried 4.335, I was on version 4.323.

The speed discrepancy was when I opened new videos in separate tabs, no closing or opening new browser sessions needed.

I'll grab the one from the git repo now and compile a indepth list of videos and get back to you, if I find anything.

[ImprovedTube]

wonderful! sent v4.337 to the stores (pending approval) (5th time in 2 weeks)

[meechgalhuquot]

Did forced playback speed get removed in the latest update? I no longer see it anywhere in the settings
Nevermind, it was just reworded and hidden behind a toggle hi! @meechgalhuquot

[Eyevou]

This video played at elevated speed despite clearly having "song" in the title.

https://www.youtube.com/watch?v=AH29SKJ_urg (Hazbin Hotel | Happy Day In Hell Full Song | Prime Video)

---

Not sure what's tripping this video to play at normal speed, it's not a song/music video, forcing playback of music jumps it.

https://www.youtube.com/watch?v=GfQYj15LKCA (Discord's Halloween Event, Free Nitro, and More!)

---

Both checked against the latest version on git, 4.358.

[ImprovedTube]

1. we still don't have the word song in the list.

   • in the title, it might not be music when combined with spotify/itunes/write a/compose/my/our etc?)
     • thus for now will only match \bfull song\b|\bsong:|\bsong[\!\$$]|^song\b|( - .*\bSong\b|\bSong\b.* - ) in titles

2. logging the following in the browser console to test (we should have a feature to show the keywords)
   category: Entertainment//title & keywords: Discord's Halloween Event, Free Nitro, and More!$discord, discord server, discord nitro free, how to get discord nitro free, discord nitro free trial, discord nitro free 2023, free discord nitro, how to get discord nitro for free, discord nitro, discord memes, discord mod, discord call sound, discord halloween, discord halloween call sound, discord ringtone, discord ringtone remix, discord poll, discord nitro gift, discord easter egg, discord bug, discord secret//music word match: true// not music word match:false//duration: PT8M54S//song duration type: long

   • limiting the match remix: if it appears in the keywords, then it must appear as a single keyword
     • adding song and music as single keyword matches too!
       • = lets see who spams these

Thank you!

[ImprovedTube]

• adding the words instrumental|backing track|medley|bootleg|mashup

• and more words to consider album durations: mixtape|concert|\b(live|cd|vinyl|lp|ep)\b

keywords

...you can watch keywords: https://chrome.google.com/webstore/detail/youtube-tags/fffiogeaioiinfekkflcfebaoiohkkgp

[Eyevou]

Instead of maintaining a list on the back end, and hoping it works for everything, what if we were to allow the user to add their own custom list that we can provide a general pre-populated list of suggestions for.