fix/youtube-page-navigation-after-video-end#3508
Open
abhisheksingh1204 wants to merge 1 commit intocode-charity:masterfrom
Open
fix/youtube-page-navigation-after-video-end#3508abhisheksingh1204 wants to merge 1 commit intocode-charity:masterfrom
abhisheksingh1204 wants to merge 1 commit intocode-charity:masterfrom
Conversation
| // if (this.video_url !== location.href) { | ||
| // this.user_interacted = false; | ||
| // } | ||
|
|
Contributor
There was a problem hiding this comment.
The combined condition mixes multiple autoplay rules in a single if, which makes it harder to reason about.
Suggest splitting into named booleans (e.g. isPlaylist, isChannelTrailer, shouldDisableAutoplay) for maintainability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YouTube is a Single Page Application (SPA) and frequently updates location.href internally without full navigation.
In the autoplay disable logic:
It was resetting user_interacted whenever location.href changed. This incorrectly treated internal SPA URL updates as a fresh navigation. As a result, the autoplay control conflicted with YouTube’s internal autoplay logic
what I have done in this PR we have removed the logic that resets user_interacted based solely on location.href changes, ensured autoplay prevention runs only on the current /watch page, prevented conflicts with YouTube’s internal SPA navigation, ensured no redirects or page replacements occur after video completion
Now the logic correctly disables autoplay and keeps the user on the same watch page