Fix: "Show remaining duration" option working properly now#3499
Open
tWiLighT-xY91 wants to merge 2 commits intocode-charity:masterfrom
Open
Fix: "Show remaining duration" option working properly now#3499tWiLighT-xY91 wants to merge 2 commits intocode-charity:masterfrom
tWiLighT-xY91 wants to merge 2 commits intocode-charity:masterfrom
Conversation
Member
|
hi, and thank you so much! @tWiLighT-xY91 |
Contributor
Author
|
Sure, I shall do it and update it asap |
Contributor
Author
|
Could you please check now and let me know? @ImprovedTube |
Member
|
hi @tWiLighT-xY91 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes an issue where enabling “Show video remaining duration” caused all player timestamps to disappear.
Recent YouTube player updates re-render the time display when internal text nodes are mutated.
The previous implementation modified
.ytp-time-duration.textContent, which triggered the player to remove the entire time UI.This change avoids mutating YouTube-owned nodes and instead injects a separate sibling element to display the remaining time, preserving the original current time and duration elements.
Tested on:
Reference:
Fixes:#3487