-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Report for issue #106 updated by RaymondFam
- Loading branch information
Showing
1 changed file
with
13 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,16 @@ | ||
## Un-indexed Parameters in Events | ||
Consider indexing parameters for events, serving as logs filter when looking for specifically wanted data. Up to three parameters in an event function can receive the attribute indexed which will cause the respective arguments to be treated as log topics instead of data. The following links are some of the instances entailed: | ||
|
||
https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/Controller.sol#L49-L56 | ||
https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/Controller.sol#L49-L56 | ||
|
||
## Unused State Variable | ||
https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/oracles/PegOracle.sol#L13 | ||
|
||
The state variable `decimals` has been assigned `priceFeed1.decimals()` in the constructor, but it is never used in the contract. It could have been used in the following line of code such that: | ||
|
||
https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/oracles/PegOracle.sol#L73 | ||
|
||
``` | ||
int256 decimals10 = int256(10**(18 - decimals); | ||
``` | ||
|