Skip to content

Commit

Permalink
Report for issue #258 updated by __141345__
Browse files Browse the repository at this point in the history
  • Loading branch information
code423n4 committed Sep 19, 2022
1 parent 2cf585d commit 58eb56b
Showing 1 changed file with 11 additions and 10 deletions.
21 changes: 11 additions & 10 deletions data/__141345__-Q.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

#### EVENT IS MISSING INDEXED FIELDS


Expand Down Expand Up @@ -76,14 +75,16 @@ src/rewards/StakingRewards.sol
```


#### Need time lock for sensitive parameter changes

When sensitive parameter changes, a time lock can give users enough time to react.










```solidity
// src/VaultFactory.sol
function setController(address _controller) public onlyAdmin {}
function changeTreasury(address _treasury, uint256 _marketIndex) public onlyAdmin {}
function changeTimewindow(uint256 _marketIndex, uint256 _timewindow) public onlyAdmin {}
function changeController(uint256 _marketIndex, address _controller) public onlyAdmin {}
function changeOracle(address _token, address _oracle) public onlyAdmin {}
```

0 comments on commit 58eb56b

Please sign in to comment.