Report for issue #106 updated by RaymondFam

data/RaymondFam-Q.md

@@ -3,7 +3,7 @@ Consider indexing parameters for events, serving as logs filter when looking for
 
 https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/Controller.sol#L49-L56
 
-## Unused State Variable
+## Unused State Variable and Unnecessary Code Line
 https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/oracles/PegOracle.sol#L13
 
 The state variable `decimals` has been assigned `priceFeed1.decimals()` in the constructor, but it is never used in the contract. It could have been used in the following line of code such that:
@@ -13,4 +13,23 @@ https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/oracles/PegOracl
 ```
         int256 decimals10 = int256(10**(18 - decimals);
 ```
+That said, line 73 could be removed, and have line 74 rewritten as follows: 
+
+https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/oracles/PegOracle.sol#L74
 
+```
+        nowPrice = nowPrice * 1e10;
+```
+This is because almost all Arbitrum data feeds entail 8 decimals, making line 73 a redundant step. 
+
+Additionally, the code logic here presumes that priceFeed1 and priceFeed2 will only be dealing with data feeds of 8 decimals. Otherwise, the following line of code could readily truncate to zero if `priceFeed1.decimals()` is equal to a different value, e.g. 18.
+
+https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/oracles/PegOracle.sol#L78
+
+## safeTransfer and safeTransferFrom
+https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/Vault.sol#L167
+https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/Vault.sol#L190
+https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/Vault.sol#L228
+https://github.com/code-423n4/2022-09-y2k-finance/blob/main/src/Vault.sol#L231
+
+`SafeTransferLib` has been inherited from `SemiFungibleVault.sol`. Where possible, use `safeTransfer` and `safeTransferFrom` instead of `transfer` and `transferFrom` since the contract is dealing with different assets in different Vaults. This would cater for non-standard ERC20 tokens that don’t have boolean return values, just in case.