Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #47

Open
code423n4 opened this issue Sep 15, 2022 · 2 comments
Open

QA Report #47

code423n4 opened this issue Sep 15, 2022 · 2 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Sep 15, 2022
code423n4 added a commit that referenced this issue Sep 15, 2022
@code423n4
rvierdiiev issue #47
2f423ae
code423n4 added a commit that referenced this issue Sep 15, 2022
@code423n4
rvierdiiev data for issue #47
87e26d6
@0xble
Copy link
Collaborator

0xble commented Sep 26, 2022

"Check that token exists to initialize crowdfund": we may want to create a crowdfund for an NFT that has yet to be released/minted.

"Use type(uint96).max instead for simplicity" is a good suggestion, we've implement it.

The others we acknowledge.

@0xble 0xble added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Sep 26, 2022
@HardlyDifficult HardlyDifficult mentioned this issue Oct 9, 2022
Closed
@HardlyDifficult
Copy link
Collaborator

Merging with #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HardlyDifficult @0xble @code423n4