Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unchecked return value of eth transfer #310

Closed
code423n4 opened this issue Sep 19, 2022 · 2 comments
Closed

Unchecked return value of eth transfer #310

code423n4 opened this issue Sep 19, 2022 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/PartyDAO/party-contracts-c4/blob/main/contracts/party/PartyGovernance.sol#L783-L796

Vulnerability details

Impact

PartyGovernance.targetAddress() makes a low-level call to send eth to a target address, however does not check if transaction is successful.

Proof of Concept

https://github.com/PartyDAO/party-contracts-c4/blob/main/contracts/party/PartyGovernance.sol#L783-L796

Tools Used

Manual review

Recommended Mitigation Steps

Add a require check for success
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Sep 19, 2022
code423n4 added a commit that referenced this issue Sep 19, 2022
@code423n4
cryptphi issue #310
e474f1a
@merklejerk merklejerk added the duplicate This issue or pull request already exists label Sep 21, 2022
@merklejerk
Copy link
Collaborator

Duplicate of #233

@merklejerk merklejerk marked this as a duplicate of #233 Sep 21, 2022
@HardlyDifficult
Copy link
Collaborator

See dupe for context.

Merging with #308

@HardlyDifficult HardlyDifficult added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax and removed 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels Oct 6, 2022
@HardlyDifficult HardlyDifficult mentioned this issue Oct 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@merklejerk @HardlyDifficult @code423n4